Skip to content

Commit d2c8e1b

Browse files
authored
fix(alert): fixed close button overlapping text #282 (#287)
1 parent 6549783 commit d2c8e1b

2 files changed

Lines changed: 17 additions & 22 deletions

File tree

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,8 +122,7 @@
122122
},
123123
"lint-staged": {
124124
"{src,tedi}/**/*.{css,scss}": [
125-
"stylelint --fix",
126-
"prettier --write"
125+
"stylelint --fix"
127126
],
128127
"src/**/*.{ts,html}": [
129128
"prettier --write"

tedi/components/notifications/alert/alert.component.scss

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
}
66

77
.tedi-alert {
8+
--_close-button-size: 18px;
9+
810
position: relative;
911
display: flex;
1012
flex-direction: column;
@@ -14,17 +16,19 @@
1416
border: 1px solid;
1517
border-radius: var(--alert-radius);
1618

17-
@include alert-variant(
18-
var(--alert-default-background-info),
19-
var(--alert-default-border-info)
20-
);
19+
@include alert-variant(var(--alert-default-background-info),
20+
var(--alert-default-border-info));
2121

2222
&__head {
2323
display: flex;
2424
gap: var(--layout-grid-gutters-04);
2525
align-items: center;
2626
}
2727

28+
&:has(&__close) {
29+
padding-right: calc(var(--layout-grid-gutters-04) + var(--_close-button-size) + var(--alert-default-padding-x));
30+
}
31+
2832
&__close {
2933
position: absolute;
3034
top: var(--alert-default-padding-y);
@@ -48,31 +52,23 @@
4852
}
4953

5054
&--info {
51-
@include alert-variant(
52-
var(--alert-default-background-info),
53-
var(--alert-default-border-info)
54-
);
55+
@include alert-variant(var(--alert-default-background-info),
56+
var(--alert-default-border-info));
5557
}
5658

5759
&--success {
58-
@include alert-variant(
59-
var(--alert-default-background-success),
60-
var(--alert-default-border-success)
61-
);
60+
@include alert-variant(var(--alert-default-background-success),
61+
var(--alert-default-border-success));
6262
}
6363

6464
&--warning {
65-
@include alert-variant(
66-
var(--alert-default-background-warning),
67-
var(--alert-default-border-warning)
68-
);
65+
@include alert-variant(var(--alert-default-background-warning),
66+
var(--alert-default-border-warning));
6967
}
7068

7169
&--danger {
72-
@include alert-variant(
73-
var(--alert-default-background-danger),
74-
var(--alert-default-border-danger)
75-
);
70+
@include alert-variant(var(--alert-default-background-danger),
71+
var(--alert-default-border-danger));
7672
}
7773

7874
&--global {

0 commit comments

Comments
 (0)