From 06e9536c1bf943f32868fc1dd911758c18bad39b Mon Sep 17 00:00:00 2001 From: Nathan Franklin Date: Wed, 25 Feb 2026 09:19:07 -0600 Subject: [PATCH 01/16] add js.configs.recommended linting --- client/eslint.config.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/client/eslint.config.ts b/client/eslint.config.ts index e96856941..e9582d081 100644 --- a/client/eslint.config.ts +++ b/client/eslint.config.ts @@ -11,6 +11,8 @@ export default defineConfig([ { files: ['**/*.{js,mjs,cjs,ts,mts,cts,jsx,tsx}'], plugins: { js }, + languageOptions: { globals: globals.jest, }, + ...js.configs.recommended, }, // tseslint.configs.recommended, pluginReact.configs.flat.recommended, From 21f18250f199c2e3f1656499b19e9f5ad169ec55 Mon Sep 17 00:00:00 2001 From: Nathan Franklin Date: Fri, 6 Mar 2026 17:01:13 -0600 Subject: [PATCH 02/16] Fix or statement --- client/src/hooks/datafiles/mutations/useTrash.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/client/src/hooks/datafiles/mutations/useTrash.ts b/client/src/hooks/datafiles/mutations/useTrash.ts index 546d2dfc8..204c67211 100644 --- a/client/src/hooks/datafiles/mutations/useTrash.ts +++ b/client/src/hooks/datafiles/mutations/useTrash.ts @@ -23,7 +23,7 @@ export async function trashUtil({ }; const response = await apiClient.put(url, body, { headers: { - 'X-CSRFToken': Cookies.get('csrftoken' || ''), + 'X-CSRFToken': Cookies.get('csrftoken') || '', }, withCredentials: true, }); From 3141dbc8410e927113c116be2dad454122cc20e9 Mon Sep 17 00:00:00 2001 From: Nathan Franklin Date: Sun, 8 Mar 2026 22:05:25 -0500 Subject: [PATCH 03/16] Add _ to unused variables --- .../components/Allocations/AllocationsCells.jsx | 2 +- .../AllocationsManageTeamTable.jsx | 2 +- .../components/Applications/AppForm/AppForm.jsx | 6 +++--- .../Applications/AppForm/AppFormSchema.js | 2 +- .../Applications/AppForm/AppFormUtils.test.js | 2 +- .../DataFilesModals/DataFilesLinkModal.jsx | 6 +++--- .../DataFilesModalListingTable.jsx | 2 +- .../DataFilesModals/DataFilesRenameModal.jsx | 4 ++-- .../DataFilesUploadModalListingTable.jsx | 2 +- .../tests/DataFilesDownloadMessageModal.test.jsx | 2 +- .../DataFilesProjectMembers.jsx | 2 +- client/src/components/Jobs/Jobs.jsx | 2 +- .../src/components/Submissions/Submissions.jsx | 2 +- .../components/SystemMonitor/SystemMonitor.jsx | 2 +- .../SystemStatusQueueTable.jsx | 2 +- .../UIPatternsButton/UIPatternsButton.jsx | 2 +- .../InfiniteScrollTable/InfiniteScrollTable.jsx | 4 ++-- client/src/hooks/datafiles/mutations/useCopy.ts | 2 +- client/src/hooks/datafiles/mutations/useTrash.ts | 2 +- .../src/hooks/datafiles/mutations/useUpload.ts | 2 +- client/src/redux/sagas/allocations.sagas.js | 6 +++--- client/src/redux/sagas/apps.sagas.js | 4 ++-- client/src/redux/sagas/datafiles.sagas.js | 16 ++++++++-------- client/src/redux/sagas/datafiles.sagas.test.js | 4 ++-- client/src/redux/sagas/jobs.sagas.js | 2 +- client/src/redux/sagas/onboarding.sagas.js | 4 ++-- client/src/redux/sagas/portalMessages.sagas.js | 8 ++++---- client/src/redux/sagas/profile.sagas.js | 2 +- client/src/redux/sagas/profile.sagas.test.js | 2 +- client/src/redux/sagas/siteSearch.sagas.js | 2 +- client/src/redux/sagas/systemMonitor.sagas.js | 2 +- client/src/redux/sagas/tickets.sagas.js | 4 ++-- client/src/redux/sagas/workbench.sagas.js | 4 ++-- client/src/utils/getCompressParams.ts | 2 +- client/src/utils/jobsUtil.js | 4 ++-- client/src/utils/renderHtml.js | 2 +- 36 files changed, 60 insertions(+), 60 deletions(-) diff --git a/client/src/components/Allocations/AllocationsCells.jsx b/client/src/components/Allocations/AllocationsCells.jsx index 45ef83d53..20cb17623 100644 --- a/client/src/components/Allocations/AllocationsCells.jsx +++ b/client/src/components/Allocations/AllocationsCells.jsx @@ -63,7 +63,7 @@ export const Remaining = ({ cell }) => { }; return (
- {cell.value.map(({ remaining, ratio, type, id }) => ( + {cell.value.map(({ remaining, ratio, type, _id }) => (
{ @@ -48,7 +48,7 @@ const DataFilesLinkActions = ({ status, onClick }) => { disabled={disabled} type="primary" size="medium" - onClick={(e) => onClick('put')} + onClick={(_e) => onClick('put')} > Replace Link @@ -61,7 +61,7 @@ const DataFilesLinkActions = ({ status, onClick }) => { disabled={disabled} type="primary" size="long" - onClick={(e) => onClick('post')} + onClick={(_e) => onClick('post')} > Generate Link diff --git a/client/src/components/DataFiles/DataFilesModals/DataFilesModalTables/DataFilesModalListingTable.jsx b/client/src/components/DataFiles/DataFilesModals/DataFilesModalTables/DataFilesModalListingTable.jsx index 6072ef4e1..62d1c1b4c 100644 --- a/client/src/components/DataFiles/DataFilesModals/DataFilesModalTables/DataFilesModalListingTable.jsx +++ b/client/src/components/DataFiles/DataFilesModals/DataFilesModalTables/DataFilesModalListingTable.jsx @@ -10,7 +10,7 @@ import { import DataFilesTable from '../../DataFilesTable/DataFilesTable'; import { FileIcon } from '../../DataFilesListing/DataFilesListingCells'; import styles from './DataFilesModalListingTable.module.scss'; -import { useSelector, shallowEqual } from 'react-redux'; +import { _useSelector, _shallowEqual } from 'react-redux'; export function getCurrentDirectory(path) { return path.split('/').pop(); diff --git a/client/src/components/DataFiles/DataFilesModals/DataFilesRenameModal.jsx b/client/src/components/DataFiles/DataFilesModals/DataFilesRenameModal.jsx index f90b8235d..0726928f7 100644 --- a/client/src/components/DataFiles/DataFilesModals/DataFilesRenameModal.jsx +++ b/client/src/components/DataFiles/DataFilesModals/DataFilesRenameModal.jsx @@ -17,14 +17,14 @@ const DataFilesRenameModal = () => { params: { api, scheme }, } = useFileListing('FilesListing'); - const { rename: renameCallback, setStatus } = useRename(); + const { rename: renameCallback, _setStatus } = useRename(); const toggle = () => toggleModal({ operation: 'rename', props: {} }); const dispatch = useDispatch(); const history = useHistory(); const location = useLocation(); - const reloadPage = (name, newPath) => { + const reloadPage = (_name, _newPath) => { history.push(location.pathname); }; diff --git a/client/src/components/DataFiles/DataFilesModals/DataFilesUploadModalListing/DataFilesUploadModalListingTable.jsx b/client/src/components/DataFiles/DataFilesModals/DataFilesUploadModalListing/DataFilesUploadModalListingTable.jsx index b692be1dd..7e05ebdf9 100644 --- a/client/src/components/DataFiles/DataFilesModals/DataFilesUploadModalListing/DataFilesUploadModalListingTable.jsx +++ b/client/src/components/DataFiles/DataFilesModals/DataFilesUploadModalListing/DataFilesUploadModalListingTable.jsx @@ -58,7 +58,7 @@ function DataFilesUploadModalListingTable({ - {uploadedFiles.map((file, i) => ( + {uploadedFiles.map((file, _i) => ( {file.data.name} diff --git a/client/src/components/DataFiles/DataFilesModals/tests/DataFilesDownloadMessageModal.test.jsx b/client/src/components/DataFiles/DataFilesModals/tests/DataFilesDownloadMessageModal.test.jsx index a206c9954..54fc2c8d3 100644 --- a/client/src/components/DataFiles/DataFilesModals/tests/DataFilesDownloadMessageModal.test.jsx +++ b/client/src/components/DataFiles/DataFilesModals/tests/DataFilesDownloadMessageModal.test.jsx @@ -93,7 +93,7 @@ describe('DataFilesDownloadMessageModal', () => { // Click on the Compress button to try and download the folder fireEvent.click(screen.getByText('Compress')); - const expectedArg = { + const _expectedArg = { filename: `Archive_${new Date().toISOString().split('.')[0]}`, files: DataFilesDownloadMessageModalFixture.files.selected.FilesListing.map( diff --git a/client/src/components/DataFiles/DataFilesProjectMembers/DataFilesProjectMembers.jsx b/client/src/components/DataFiles/DataFilesProjectMembers/DataFilesProjectMembers.jsx index 165191e52..42dd99e27 100644 --- a/client/src/components/DataFiles/DataFilesProjectMembers/DataFilesProjectMembers.jsx +++ b/client/src/components/DataFiles/DataFilesProjectMembers/DataFilesProjectMembers.jsx @@ -160,7 +160,7 @@ const DataFilesProjectMembers = ({ el.row.original.access !== 'owner' && !readOnlyTeam ? (