Parsing fails when swimmer DOB is not provided

[JrryChen]

Hi, i'm exploring your package for my own usage in an application.

When I run the hy3_parser in my sample meet, I'm getting an error due to a line code of "B3"

It looks like the b_meet_parsers.py can't handle this line.

When I go to my meet file, B3 file line is essentially empty.

[JrryChen]

---

ValueError Traceback (most recent call last)
File c:\Users\chess\OneDrive\Documents\ISCAClient\ISCAPointScorer.venv\Lib\site-packages\hytek_parser\hy3_parser.py:62, in parse_hy3(file, validate_checksums, default_country)
60 continue
---> 62 parsed_file = line_parser(line, parsed_file, opts)
63 except Exception as e:

File c:\Users\chess\OneDrive\Documents\ISCAClient\ISCAPointScorer.venv\Lib\site-packages\hytek_parser\hy3\line_parsers\d_swimmer_parsers.py:28, in d1_parser(line, file, opts)
26 swimmer.team_id = int(team_id)
---> 28 swimmer.date_of_birth = datetime.strptime(extract(line, 89, 8), "%m%d%Y").date()
29 swimmer.age = int(extract(line, 97, 3))

File ~\AppData\Local\Programs\Python\Python313\Lib_strptime.py:676, in _strptime_datetime(cls, data_string, format)
674 """Return a class cls instance based on the input string and the
675 format string."""
--> 676 tt, fraction, gmtoff_fraction = _strptime(data_string, format)
677 tzname, gmtoff = tt[-2:]

File ~\AppData\Local\Programs\Python\Python313\Lib_strptime.py:455, in _strptime(data_string, format)
454 if not found:
--> 455 raise ValueError("time data %r does not match format %r" %
456 (data_string, format))
457 if len(data_string) != found.end():

ValueError: time data '' does not match format '%m%d%Y'

The above exception was the direct cause of the following exception:

RuntimeError Traceback (most recent call last)
Cell In[2], line 3
1 file_path = "../SampleMeetResults/Meet Results-PCS Spring Home Meet 2025-22Mar2025-002.hy3"
----> 3 parsed_file = hy3_parser.parse_hy3(file_path)
4 print(parsed_file)

File c:\Users\chess\OneDrive\Documents\ISCAClient\ISCAPointScorer.venv\Lib\site-packages\hytek_parser\hy3_parser.py:65, in parse_hy3(file, validate_checksums, default_country)
63 except Exception as e:
64 msg = "Exception while parsing, please open an issue with full traceback at https://github.com/SwimComm/hytek-parser/issues/new/choose"
---> 65 raise RuntimeError(msg) from e # TODO: actual error handling
67 # logger.success(
68 # f"Parse completed with {warnings} warning(s) and {errors} error(s)."
69 # )
70 return parsed_file

RuntimeError: Exception while parsing, please open an issue with full traceback at https://github.com/SwimComm/hytek-parser/issues/new/choose

[hansenmc]

It appears that B3 is the Meet Contact info:
https://groups.google.com/g/sdif-forum/c/jGi-watQucs

// +----Line code (A1 = File Descriptor)
// (B1 = Meet Information)
// (B2 = Meet Address)
// (B3 = Meet Contact)

And there currently is not a line parser for B3:
https://github.com/SwimComm/hytek-parser/blob/master/hytek_parser/hy3/line_parsers/__init__.py#L23

It looks like it should have printed:

"Invalid line code: B3"

and then continued, ignoring that line.
https://github.com/SwimComm/hytek-parser/blob/master/hytek_parser/hy3_parser.py#L58

Is the error and stack trace you posted the result of attempting to parse a hy3 file that has the B3 line, or from a different file?

The stack trace indicates that the swimmer date of birth is an empty string, rather than the 8 numbers that need to be parsed:

ValueError: time data '' does not match format '%m%d%Y'

when it attempts to extract the swimmer date of birth:

---> 28 swimmer.date_of_birth = datetime.strptime(extract(line, 89, 8), "%m%d%Y").date()

Can you verify that all of the swimmers have date of birth populated?

[JrryChen]

Yeah I just realized this, sorry that was dumb of me

It was due to the swimmer's DOB being missing. Since this sample file is from a college club meet, I'm guessing the DOB is missing. I fixed this issue by putting a placeholder DOB when it is empty.

I'm running into that issue again when doing an E2 event line is missing a date. Do you have any recommendations other than a placeholder date?

[hansenmc]

At the moment, it appears that Swimmer DOB is required.

It might be possible to change the schema and parsing to accommodate a missing date. Would need to see where it's used and ensure that downstream processing of Swimmer can handle None instead of a date object. Otherwise, you just move where it blows up from the parsing of the file to all of the places where Swimmer DOB is used.

Maybe having an option to substitute a default DOB when missing, similar to how default Country is "USA" and can specify a default_country value:

hytek-parser/hytek_parser/hy3_parser.py

Line 9 in ebea9a8

file: StrOrBytesPath, validate_checksums: bool = False, default_country: str = "USA"

[egelja]

Thanks for reporting this!

If there was to be a default, I'd probably choose 1970-01-01, but I think updating the schema so DOB can be None would be best, as its more explicit. I don't believe anything downstream checks that field, but would need to double check.

Also, I split out the need for parsing B3 lines into another issue (#14).

[hansenmc]

When the date of birth was not specified, was the age specified either? If adjusting for DOB to be None might also want to adjust when reading the age to use int_or_none() instead of int()

https://github.com/SwimComm/hytek-parser/blob/master/hytek_parser/hy3/line_parsers/d_swimmer_parsers.py#L26

[hansenmc]

@JrryChen can you confirm whether the Swimmer Age was specified when the DOB was not?

If DOB is not known then you might also not know their age. It's currently required and would result in the same sort of error unless adjustments are also made to handle when Age is blank.

@egelja I've got the changes applied making both DOB and Age optional (with tests), but can roll back and leave Age as required. Let me know what you think and I can submit a PR.

[JrryChen]

It seems like AGE defaulted to 0 if there was no AGE specified. Some athletes only had AGE specified and no DOB.

[JrryChen]

To clairfy, it was 0 in the .hy3 file, not empty when parsing.

Sorry for late responses and unclear comments, pulled thin between multiple projects and finals right now.

[egelja]

Just published a new release (v1.2.0), let me know if the issue is fixed @hansenmc @JrryChen