refactor: access to private constructor / remove edit icon method

Author: SuperCrafting

src/main/java/pt/supercrafting/menu/Menu.java

@@ -45,7 +45,7 @@ public Menu(@NotNull Component title, @NotNull InventoryType type) {
     }
 
     @ApiStatus.Internal
-    private Menu(@NotNull Component title, @NotNull InventoryType type, int size) {
+    protected Menu(@NotNull Component title, @NotNull InventoryType type, int size) {
 
         this.slots = new Int2ObjectArrayMap<>(size);
         for (int i = 0; i < size; i++)

src/main/java/pt/supercrafting/menu/item/MenuItem.java

@@ -57,11 +57,6 @@ public void itemStack(@NotNull ItemStack itemStack) {
 
     }
 
-    @Override
-    public void icon(@NotNull ItemStack itemStack) {
-
-    }
-
     protected final void superTake(@NotNull Take take) {
         MenuSlot.super.take(take);
     }

…t/supercrafting/menu/plugin/MenuAPI.java …upercrafting/menu/plugin/MenuPlugin.javasrc/main/java/pt/supercrafting/menu/plugin/MenuAPI.java renamed to src/main/java/pt/supercrafting/menu/plugin/MenuPlugin.java src/main/java/pt/supercrafting/menu/plugin/MenuAPI.java renamed to src/main/java/pt/supercrafting/menu/plugin/MenuPlugin.java

@@ -5,7 +5,7 @@
 import org.bukkit.plugin.java.JavaPlugin;
 import pt.supercrafting.menu.MenuManager;
 
-public final class MenuAPI extends JavaPlugin {
+public final class MenuPlugin extends JavaPlugin {
 
     @Override
     public void onEnable() {

src/main/java/pt/supercrafting/menu/slot/ForbiddenSlot.java

@@ -16,11 +16,6 @@ private ForbiddenSlot() {
         return icon;
     }
 
-    @Override
-    public void icon(@NotNull ItemStack itemStack) {
-
-    }
-
     @Override
     public @NotNull ItemStack itemStack() {
         return ItemStack.empty();

src/main/java/pt/supercrafting/menu/slot/MenuSlot.java

@@ -18,10 +18,6 @@ public interface MenuSlot {
 
     // Displayed item
 
-    default void icon(@NotNull ItemStack itemStack) {
-        itemStack(itemStack);
-    }
-
     @NotNull
     default ItemStack icon() {
         return itemStack();