Skip to content

You can't remove aliases, only add new. #114

@LeMyst

Description

@LeMyst

The set_aliases function take a list of strings as parameters, check if the alias already exist or not and add the missings one to the list.
At the moment, we can't (afaik) remove alias on an item.

I propose two options (breaking changes) :

  • Update the set_aliases function to test if aliases parameters is a string or list :
    • If a string, add the alias to the aliases (if missing)
    • If a list, replace all the current aliases by the new list
  • Update the set_aliases function and add a new add_alias :
    • set_aliases take a list of string as parameter and replace the current aliases by the new ones
    • add_alias take a string as parameter and add it to the current list of aliases

I don't know which one is better, but atm we don't have any add_ or rem_ functions, only get_ and set_.

This issue is open for comments. 😉

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions