Feat/escrow lifecycle fix#253
Merged
Merged
Conversation
…crow, dispute, expiration, and error flows
Contributor
Author
|
@KuchiMercy , Hello maintainers please kindly approve the workflow, review for your concern. |
Cedarich
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes TypeORM typing inconsistencies in escrow lifecycle event logging and resolves CI lint/build failures.
Changes
typeandeventTypein EscrowEvent entity usageanyandrequire()usage in test mocksTesting
Risk Level
Low – internal service layer only, no API contract changes
Closing
closes #198
closes #203