STAC-24049: process feedback

remove unnecessary empty check

Author: deontaljaard

cmd/otelcomponentmapping/otelcomponentmapping_delete.go

@@ -36,10 +36,6 @@ func RunDeleteComponentMappingCommand(args *DeleteArgs) di.CmdWithApiFn {
 		api *stackstate_api.APIClient,
 		serverInfo *stackstate_api.ServerInfo,
 	) common.CLIError {
-		if args.Identifier == "" {
-			return common.NewCLIArgParseError(fmt.Errorf("--identifier is required"))
-		}
-
 		resp, err := api.OtelMappingApi.DeleteOtelComponentMapping(cli.Context, args.Identifier).Execute()
 		if err != nil {
 			return common.NewResponseError(err, resp)

cmd/otelcomponentmapping/otelcomponentmapping_describe.go

@@ -38,12 +38,7 @@ sts otel-component-mapping describe --identifier urn:stackpack:stackpack-name:sh
 
 func RunDescribeComponentMappingCommand(args *DescribeArgs) di.CmdWithApiFn {
 	return func(cmd *cobra.Command, cli *di.Deps, api *stackstate_api.APIClient, serverInfo *stackstate_api.ServerInfo) common.CLIError {
-		if args.Identifier == "" {
-			return common.NewCLIArgParseError(fmt.Errorf("--identifier is required"))
-		}
-		ref := args.Identifier
-
-		mapping, resp, err := api.OtelMappingApi.GetOtelComponentMapping(cli.Context, ref).Execute()
+		mapping, resp, err := api.OtelMappingApi.GetOtelComponentMapping(cli.Context, args.Identifier).Execute()
 		if err != nil {
 			return common.NewResponseError(err, resp)
 		}

cmd/otelcomponentmapping/otelcomponentmapping_edit.go

@@ -41,10 +41,6 @@ sts otel-component-mapping edit --identifier urn:stackpack:stackpack-name:shared
 
 func RunEditComponentMappingCommand(args *EditArgs) di.CmdWithApiFn {
 	return func(cmd *cobra.Command, cli *di.Deps, api *stackstate_api.APIClient, serverInfo *stackstate_api.ServerInfo) common.CLIError {
-		if args.Identifier == "" {
-			return common.NewCLIArgParseError(fmt.Errorf("--identifier is required"))
-		}
-
 		mapping, resp, err := api.OtelMappingApi.GetOtelComponentMapping(cli.Context, args.Identifier).Execute()
 		if err != nil {
 			return common.NewResponseError(err, resp)

cmd/otelrelationmapping/otelrelationmapping_delete.go

@@ -36,10 +36,6 @@ func RunDeleteRelationMappingCommand(args *DeleteArgs) di.CmdWithApiFn {
 		api *stackstate_api.APIClient,
 		serverInfo *stackstate_api.ServerInfo,
 	) common.CLIError {
-		if args.Identifier == "" {
-			return common.NewCLIArgParseError(fmt.Errorf("--identifier is required"))
-		}
-
 		resp, err := api.OtelMappingApi.DeleteOtelRelationMapping(cli.Context, args.Identifier).Execute()
 		if err != nil {
 			return common.NewResponseError(err, resp)

cmd/otelrelationmapping/otelrelationmapping_describe.go

@@ -36,12 +36,7 @@ sts otel-relation-mapping describe --identifier urn:stackpack:stackpack-name:sha
 
 func RunDescribeRelationMappingCommand(args *DescribeArgs) di.CmdWithApiFn {
 	return func(cmd *cobra.Command, cli *di.Deps, api *stackstate_api.APIClient, serverInfo *stackstate_api.ServerInfo) common.CLIError {
-		if args.Identifier == "" {
-			return common.NewCLIArgParseError(fmt.Errorf("--identifier is required"))
-		}
-		ref := args.Identifier
-
-		mapping, resp, err := api.OtelMappingApi.GetOtelRelationMapping(cli.Context, ref).Execute()
+		mapping, resp, err := api.OtelMappingApi.GetOtelRelationMapping(cli.Context, args.Identifier).Execute()
 		if err != nil {
 			return common.NewResponseError(err, resp)
 		}

cmd/otelrelationmapping/otelrelationmapping_edit.go

@@ -39,12 +39,7 @@ sts otel-relation-mapping edit --identifier urn:stackpack:stackpack-name:shared:
 
 func RunEditRelationMappingCommand(args *EditArgs) di.CmdWithApiFn {
 	return func(cmd *cobra.Command, cli *di.Deps, api *stackstate_api.APIClient, serverInfo *stackstate_api.ServerInfo) common.CLIError {
-		if args.Identifier == "" {
-			return common.NewCLIArgParseError(fmt.Errorf("--identifier is required"))
-		}
-		identifier := args.Identifier
-
-		mapping, resp, err := api.OtelMappingApi.GetOtelRelationMapping(cli.Context, identifier).Execute()
+		mapping, resp, err := api.OtelMappingApi.GetOtelRelationMapping(cli.Context, args.Identifier).Execute()
 		if err != nil {
 			return common.NewResponseError(err, resp)
 		}