STAC-0: fix fresh linting issues

Author: dottorblaster

cmd/dashboard/dashboard_edit_test.go

@@ -96,7 +96,7 @@ func TestShouldEditDashboard(t *testing.T) {
 			"scope": "privateDashboard"
 		}`),
 	}
-	cli.Deps.Editor = mockEditor
+	cli.Editor = mockEditor
 
 	di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "--id", "1234")
 
@@ -136,7 +136,7 @@ func TestShouldEditDashboardWithIdentifier(t *testing.T) {
 			"description": "Updated via identifier"
 		}`),
 	}
-	cli.Deps.Editor = mockEditor
+	cli.Editor = mockEditor
 
 	di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "--identifier", "urn:custom:dashboard:edit-test")
 
@@ -153,7 +153,7 @@ func TestEditDashboardNoChanges(t *testing.T) {
 
 	// Custom editor that returns exactly the same content as input
 	noChangeEditor := &NoChangeEditor{}
-	cli.Deps.Editor = noChangeEditor
+	cli.Editor = noChangeEditor
 
 	di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "--id", "1234")
 
@@ -186,7 +186,7 @@ func TestEditDashboardWithJsonOutput(t *testing.T) {
 			"description": "Testing JSON output"
 		}`),
 	}
-	cli.Deps.Editor = mockEditor
+	cli.Editor = mockEditor
 
 	di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "--id", "1234", "--output", "json")
 
@@ -204,7 +204,7 @@ func TestEditDashboardNoChangesJsonOutput(t *testing.T) {
 
 	// Use NoChangeEditor that returns exactly the same content
 	noChangeEditor := &NoChangeEditor{}
-	cli.Deps.Editor = noChangeEditor
+	cli.Editor = noChangeEditor
 
 	di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "--id", "1234", "--output", "json")
 
@@ -223,6 +223,7 @@ func TestEditDashboardInvalidJson(t *testing.T) {
 	mockEditor := &MockEditor{
 		Content: []byte(`{"invalid": json syntax}`),
 	}
+	//nolint:staticcheck
 	cli.Deps.Editor = mockEditor
 
 	_, err := di.ExecuteCommandWithContext(&cli.Deps, cmd, "--id", "1234")
@@ -242,6 +243,7 @@ func TestEditDashboardEditorError(t *testing.T) {
 	mockEditor := &MockEditor{
 		Error: errors.New("editor failed to open"),
 	}
+	//nolint:staticcheck
 	cli.Deps.Editor = mockEditor
 
 	_, err := di.ExecuteCommandWithContext(&cli.Deps, cmd, "--id", "1234")
@@ -275,7 +277,7 @@ func TestEditDashboardUsesReverseEditorByDefault(t *testing.T) {
 	mockEditor := &MockEditor{
 		Content: []byte(`{"name": "changed-by-reverse-editor"}`),
 	}
-	cli.Deps.Editor = mockEditor
+	cli.Editor = mockEditor
 
 	di.ExecuteCommandWithContextUnsafe(&cli.Deps, cmd, "--id", "1234")
 
@@ -324,7 +326,7 @@ func TestEditDashboardApiErrors(t *testing.T) {
 				mockEditor := &MockEditor{
 					Content: []byte(`{"name": "changed"}`),
 				}
-				cli.Deps.Editor = mockEditor
+				cli.Editor = mockEditor
 			}
 
 			_, err := di.ExecuteCommandWithContext(&cli.Deps, cmd, "--id", "1234")

cmd/stackpack/stackpack_describe.go

@@ -85,6 +85,7 @@ func RunStackpackDescribeCommand(args *DescribeArgs) di.CmdWithApiFn {
 			}
 		}
 
+		//nolint:staticcheck
 		notFound := fmt.Errorf("StackPack '%s' not found.", args.Name)
 		if cli.IsJson() {
 			cli.Printer.PrintErrJson(notFound)

cmd/stackpack/stackpack_test_cmd_test.go

@@ -437,6 +437,7 @@ func TestConfirmUpload(t *testing.T) {
 	// In a real test environment, you'd mock the stdin reader
 
 	// Just verify the function signature is correct
+	//nolint:staticcheck
 	var confirmFunc func(*di.Deps, string) bool = confirmUpload
 	assert.NotNil(t, confirmFunc)
 

internal/client/stackstate_version.go

@@ -63,5 +63,5 @@ func CheckVersionCompatibility(version stackstate_api.ServerVersion, minVersion
 }
 
 func NewAPIVersionMismatchError(got string, expected string) common.CLIError {
-	return common.NewAPIVersionError(fmt.Errorf("Incompatible API version: got '%s', but need '%s'-compatible version", got, expected))
+	return common.NewAPIVersionError(fmt.Errorf("incompatible API version: got '%s', but need '%s'-compatible version", got, expected))
 }

internal/config/config.go

@@ -81,7 +81,7 @@ func (c *Config) GetContext(name string) (*NamedContext, common.CLIError) {
 		}
 	}
 
-	return nil, common.NewNotFoundError(fmt.Errorf("Context with name '%s' not found", name))
+	return nil, common.NewNotFoundError(fmt.Errorf("context with name '%s' not found", name))
 }
 
 // UnmarshalYAML unmarshals the StsContext YAML part into a struct, ensuring that any defaults are set.
@@ -153,7 +153,7 @@ func (c *StsContext) Validate(contextName string) common.CLIError {
 
 	authenticationTokens := util.RemoveEmpty([]string{c.APIToken, c.ServiceToken, c.K8sSAToken})
 	if len(authenticationTokens) > 1 {
-		errors = append(errors, fmt.Errorf("Can only specify one of {api-token | service-token | k8s-sa-token}"))
+		errors = append(errors, fmt.Errorf("can only specify one of {api-token | service-token | k8s-sa-token}"))
 	}
 
 	if c.HasCaCertificateFromArgSet() {

internal/config/config_test.go

@@ -181,7 +181,7 @@ current-context: default
 	assert.NoError(t, err)
 	assert.ErrorContains(t, c.Contexts[0].Context.Validate(c.Contexts[0].Name), `Failed to validate the 'default' context:
 * URL localhost:8080 must start with "https://" or "http://"
-* Can only specify one of {api-token | service-token | k8s-sa-token}`)
+* can only specify one of {api-token | service-token | k8s-sa-token}`)
 }
 
 func TestMergeWithNoTokenOverride(t *testing.T) {

pkg/pflags/relative_time_flag.go

@@ -116,7 +116,7 @@ func (d *RelativeTimeValue) Type() string {
 	return RelativeTimeFlagType
 }
 
-func (d *RelativeTimeValue) String() string { return d.Time.Format(time.RFC3339Nano) }
+func (d *RelativeTimeValue) String() string { return d.Format(time.RFC3339Nano) }
 
 // GetRelativeTime return the time value of a flag with the given name
 func GetRelativeTime(f *pflag.FlagSet, name string) (time.Time, error) {