Skip to content

Commit 5b8ffe5

Browse files
committed
STAC-23287: Address comments
1 parent 99f50eb commit 5b8ffe5

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

cmd/stackpack/stackpack_install.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ type InstallArgs struct {
1717
Name string
1818
UnlockedStrategy string
1919
Params map[string]string
20-
Wait bool // New: whether to wait for installation to complete
21-
Timeout time.Duration // New: timeout for wait operation
20+
Wait bool
21+
Timeout time.Duration
2222
}
2323

2424
func StackpackInstallCommand(cli *di.Deps) *cobra.Command {
@@ -61,7 +61,7 @@ func RunStackpackInstallCommand(args *InstallArgs) di.CmdWithApiFn {
6161
return common.NewResponseError(err, resp)
6262
}
6363

64-
// New wait functionality: monitor installation until completion
64+
// Wait functionality: monitor installation until completion
6565
if args.Wait {
6666
if !cli.IsJson() {
6767
cli.Printer.PrintLn("Waiting for installation to complete...")
@@ -121,7 +121,6 @@ func RunStackpackInstallCommand(args *InstallArgs) di.CmdWithApiFn {
121121
)
122122
}
123123
} else {
124-
// Original behavior - just show the immediate response
125124
if cli.IsJson() {
126125
cli.Printer.PrintJson(map[string]interface{}{
127126
"instance": instance,

cmd/stackpack/stackpack_upgrade.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ var (
2121
type UpgradeArgs struct {
2222
TypeName string
2323
UnlockedStrategy string
24-
Wait bool // New: whether to wait for upgrade to complete
25-
Timeout time.Duration // New: timeout for wait operation
24+
Wait bool
25+
Timeout time.Duration
2626
}
2727

2828
func StackpackUpgradeCommand(cli *di.Deps) *cobra.Command {
@@ -68,7 +68,7 @@ func RunStackpackUpgradeCommand(args *UpgradeArgs) di.CmdWithApiFn {
6868
return common.NewResponseError(err, resp)
6969
}
7070

71-
// New wait functionality: monitor upgrade until completion
71+
// Wait functionality: monitor upgrade until completion
7272
if args.Wait {
7373
if !cli.IsJson() {
7474
cli.Printer.PrintLn("Waiting for upgrade to complete...")
@@ -129,7 +129,6 @@ func RunStackpackUpgradeCommand(args *UpgradeArgs) di.CmdWithApiFn {
129129
)
130130
}
131131
} else {
132-
// Original behavior - just show the immediate response
133132
if cli.IsJson() {
134133
cli.Printer.PrintJson(map[string]interface{}{
135134
"success": true,

0 commit comments

Comments
 (0)