STAC-22609: Improving logging

Author: viliakov

cmd/stackpack/common.go

@@ -105,7 +105,7 @@ func (w *OperationWaiter) WaitForCompletion(options WaitOptions) error {
 
 			// Return immediately if any configuration has failed
 			if len(errorMessages) > 0 {
-				return fmt.Errorf("stackpack '%s' installation failed:\n%s", options.StackPackName, strings.Join(errorMessages, "\n"))
+				return fmt.Errorf("stackpack '%s' failed:\n%s", options.StackPackName, strings.Join(errorMessages, "\n"))
 			}
 
 			// Success: all configurations are installed and none are provisioning

cmd/stackpack/stackpack_package.go

@@ -195,7 +195,7 @@ func RunStackpackPackageCommand(args *PackageArgs) func(cli *di.Deps, cmd *cobra
 				"source_dir":        args.StackpackDir,
 			})
 		} else {
-			cli.Printer.Successf("✓ Stackpack packaged successfully!")
+			cli.Printer.Successf("Stackpack packaged successfully!")
 			cli.Printer.PrintLn("")
 			cli.Printer.PrintLn(fmt.Sprintf("Stackpack: %s (v%s)", stackpackInfo.Name, stackpackInfo.Version))
 			cli.Printer.PrintLn(fmt.Sprintf("Zip file: %s", args.ArchiveFile))

cmd/stackpack/stackpack_package_test.go

@@ -79,7 +79,7 @@ func TestStackpackPackageCommand_DefaultBehavior(t *testing.T) {
 	// Verify text output
 	require.NotEmpty(t, *cli.MockPrinter.SuccessCalls)
 	successCall := (*cli.MockPrinter.SuccessCalls)[0]
-	assert.Contains(t, successCall, "✓ Stackpack packaged successfully!")
+	assert.Contains(t, successCall, "Stackpack packaged successfully!")
 
 	require.NotEmpty(t, *cli.MockPrinter.PrintLnCalls)
 	printLnCalls := *cli.MockPrinter.PrintLnCalls
@@ -143,7 +143,7 @@ func TestStackpackPackageCommand_ForceFlag(t *testing.T) {
 	// Verify success message
 	require.NotEmpty(t, *cli2.MockPrinter.SuccessCalls)
 	successCall := (*cli2.MockPrinter.SuccessCalls)[0]
-	assert.Contains(t, successCall, "✓ Stackpack packaged successfully!")
+	assert.Contains(t, successCall, "Stackpack packaged successfully!")
 }
 
 func TestStackpackPackageCommand_JSONOutput(t *testing.T) {
@@ -568,7 +568,7 @@ func TestStackpackPackageCommand_TextOutput(t *testing.T) {
 				// Verify success message
 				require.NotEmpty(t, *cli.MockPrinter.SuccessCalls)
 				successCall := (*cli.MockPrinter.SuccessCalls)[0]
-				assert.Contains(t, successCall, "✓ Stackpack packaged successfully!")
+				assert.Contains(t, successCall, "Stackpack packaged successfully!")
 
 				// Verify stackpack info is printed
 				printLnCalls := *cli.MockPrinter.PrintLnCalls

cmd/stackpack/stackpack_scaffold.go

@@ -155,7 +155,7 @@ func RunStackpackScaffoldCommand(args *ScaffoldArgs) func(cli *di.Deps, cmd *cob
 			})
 		} else {
 			// Display success message and next steps
-			cli.Printer.Successf("✓ Scaffold complete!")
+			cli.Printer.Successf("Scaffold complete!")
 			cli.Printer.PrintLn("")
 			displayNextSteps(cli, args)
 		}

cmd/stackpack/stackpack_test_cmd.go

@@ -160,7 +160,7 @@ func RunStackpackTestCommand(args *TestArgs) di.CmdWithApiFn {
 		if err := copyDirectory(args.StackpackDir, tempStackpackDir); err != nil {
 			return common.NewRuntimeError(fmt.Errorf("failed to copy stackpack to temporary directory: %w", err))
 		}
-		cli.Printer.Success("✓ Temporary copy created")
+		cli.Printer.Success("Temporary copy created")
 
 		// Step 3: Update version in temporary copy
 		cli.Printer.PrintLn("")
@@ -171,7 +171,7 @@ func RunStackpackTestCommand(args *TestArgs) di.CmdWithApiFn {
 		if err != nil {
 			return common.NewRuntimeError(fmt.Errorf("failed to bump version: %w", err))
 		}
-		cli.Printer.Success(fmt.Sprintf("✓ Version bumped to: %s", newVersion))
+		cli.Printer.Success(fmt.Sprintf("Version bumped to: %s", newVersion))
 
 		// Step 4: Package stackpack from temporary directory
 		cli.Printer.PrintLn("")
@@ -188,7 +188,7 @@ func RunStackpackTestCommand(args *TestArgs) di.CmdWithApiFn {
 		if err := runPackageStep(cli, packageArgs); err != nil {
 			return err
 		}
-		cli.Printer.Success("✓ Stackpack packaged successfully")
+		cli.Printer.Success("Stackpack packaged successfully")
 
 		// Step 5: Confirm upload (if needed) and execute upload/install workflow
 		if !args.Yes {
@@ -208,7 +208,7 @@ func RunStackpackTestCommand(args *TestArgs) di.CmdWithApiFn {
 		if err := runUploadStep(cli, api, serverInfo, uploadArgs); err != nil {
 			return err
 		}
-		cli.Printer.Success("✓ Stackpack uploaded successfully")
+		cli.Printer.Success("Stackpack uploaded successfully")
 
 		// Install or upgrade stackpack based on installation status
 		if installedVersion != "" {
@@ -222,7 +222,7 @@ func RunStackpackTestCommand(args *TestArgs) di.CmdWithApiFn {
 			if err := runUpgradeStep(cli, api, serverInfo, upgradeArgs); err != nil {
 				return err
 			}
-			cli.Printer.Success("✓ Stackpack upgraded successfully")
+			cli.Printer.Success("Stackpack upgraded successfully")
 		} else {
 			installArgs := &InstallArgs{
 				Name:             originalInfo.Name,
@@ -235,7 +235,7 @@ func RunStackpackTestCommand(args *TestArgs) di.CmdWithApiFn {
 			if err := runInstallStep(cli, api, serverInfo, installArgs); err != nil {
 				return err
 			}
-			cli.Printer.Success("✓ Stackpack installed successfully")
+			cli.Printer.Success("Stackpack installed successfully")
 		}
 
 		cli.Printer.PrintLn("")