Update simple editors to use UI abstraction layer

Convert 7 remaining simple editors to use ActionButton/EditorButton
abstractions and new Finalize API:
- metal_editor.lua: ActionButton for btnSetMetal, EditorButton for controls
- grass_editor.lua: ActionButton for btnAddGrass
- water_editor.lua: Use fields-only Finalize()
- lighting_editor.lua: Use fields-only Finalize()
- sky_editor.lua: Use fields-only Finalize()
- terrain_settings_editor.lua: Use fields-only Finalize()
- scenario_info_view.lua: Use fields-only Finalize()

All editors now use new Finalize({actionButtons = {...}}) API and
are completely UI-agnostic with no direct Chili component usage.

Author: claude

scen_edit/view/general/scenario_info_view.lua

@@ -49,21 +49,9 @@ function ScenarioInfoView:init()
         })
     )
 
-    local children = {
-        ScrollPanel:New {
-            x = 0,
-            y = 0,
-            bottom = 30,
-            right = 0,
-            borderColor = {0,0,0,0},
-            horizontalScrollbar = false,
-            children = { self.stackPanel },
-        },
-    }
-
     SB.model.scenarioInfo:addListener(ScenarioInfoListenerWidget(self))
 
-    self:Finalize(children)
+    self:Finalize()
 end
 
 function ScenarioInfoView:OnStartChange(name)

scen_edit/view/map/grass_editor.lua

@@ -37,7 +37,7 @@ function GrassEditor:init()
             SB.model.terrainManager:generateShape(texture)
         end
     }))
-    self.btnAddGrass = TabbedPanelButton({
+    self.btnAddGrass = ActionButton({
         x = 0,
         y = 0,
         tooltip = "Left Click to add grass, Right Click to remove it.",
@@ -83,19 +83,9 @@ function GrassEditor:init()
         tooltip = "Rotation of the shape",
     }))
 
-    local children = {
-        self.btnAddGrass,
-        ScrollPanel:New {
-            x = 0,
-            y = 70,
-            bottom = 30,
-            right = 0,
-            borderColor = {0,0,0,0},
-            horizontalScrollbar = false,
-            children = { self.stackPanel },
-        },
-    }
-    self:Finalize(children)
+    self:Finalize({
+        actionButtons = { self.btnAddGrass }
+    })
 end
 
 function GrassEditor:OnFieldChange(name, value)

scen_edit/view/map/lighting_editor.lua

@@ -136,21 +136,9 @@ function LightingEditor:init()
 
     self:UpdateLighting()
 
-    local children = {
-        ScrollPanel:New {
-            x = 0,
-            y = 0,
-            bottom = 30,
-            right = 0,
-            borderColor = {0,0,0,0},
-            horizontalScrollbar = false,
-            children = { self.stackPanel },
-        },
-    }
-
     SB.commandManager:addListener(self)
 
-    self:Finalize(children)
+    self:Finalize()
 end
 
 function LightingEditor:UpdateLighting()

scen_edit/view/map/metal_editor.lua

@@ -37,7 +37,7 @@ function MetalEditor:init()
             SB.model.terrainManager:generateShape(texture)
         end
     }))
-    self.btnSetMetal = TabbedPanelButton({
+    self.btnSetMetal = ActionButton({
         x = 0,
         y = 0,
         tooltip = "Left Click to set metal. Right click to remove it.",
@@ -56,7 +56,7 @@ function MetalEditor:init()
     })
 
     self:AddControl("btn-show-metal", {
-        Button:New {
+        EditorButton {
             caption = "Show metal map",
             width = 200,
             height = 40,
@@ -93,19 +93,9 @@ function MetalEditor:init()
         tooltip = "Amount of metal",
     }))
 
-    local children = {
-        self.btnSetMetal,
-        ScrollPanel:New {
-            x = 0,
-            y = 70,
-            bottom = 30,
-            right = 0,
-            borderColor = {0,0,0,0},
-            horizontalScrollbar = false,
-            children = { self.stackPanel },
-        },
-    }
-    self:Finalize(children)
+    self:Finalize({
+        actionButtons = { self.btnSetMetal }
+    })
 end
 
 function MetalEditor:IsValidState(state)

scen_edit/view/map/sky_editor.lua

@@ -78,21 +78,9 @@ function SkyEditor:init()
     }))
     self:UpdateAtmosphere()
 
-    local children = {
-        ScrollPanel:New {
-            x = 0,
-            y = 0,
-            bottom = 30,
-            right = 0,
-            borderColor = {0,0,0,0},
-            horizontalScrollbar = false,
-            children = { self.stackPanel },
-        },
-    }
-
     SB.commandManager:addListener(self)
 
-    self:Finalize(children)
+    self:Finalize()
 end
 
 function SkyEditor:UpdateAtmosphere()

scen_edit/view/map/terrain_settings_editor.lua

@@ -48,19 +48,7 @@ function TerrainSettingsEditor:init()
     self:_AddMapTextureControls()
     -- self:_AddMapCompileControls()
 
-    local children = {
-        ScrollPanel:New {
-            x = 0,
-            y = 0,
-            bottom = 30,
-            right = 0,
-            borderColor = {0,0,0,0},
-            horizontalScrollbar = false,
-            children = { self.stackPanel },
-        },
-    }
-
-    self:Finalize(children)
+    self:Finalize()
 end
 
 function TerrainSettingsEditor:_AddMapTextureControls()

scen_edit/view/map/water_editor.lua

@@ -269,21 +269,9 @@ function WaterEditor:init()
 
     self:UpdateWaterRendering()
 
-    local children = {
-        ScrollPanel:New {
-            x = 0,
-            y = 0,
-            bottom = 30,
-            right = 0,
-            borderColor = {0,0,0,0},
-            horizontalScrollbar = false,
-            children = { self.stackPanel },
-        },
-    }
-
     SB.commandManager:addListener(self)
 
-    self:Finalize(children)
+    self:Finalize()
 end
 
 function WaterEditor:UpdateWaterRendering()