Try global install here too

Author: rowleya

.github/workflows/c_actions.yml

@@ -39,15 +39,6 @@ jobs:
       with:
         python-version: 3.12
 
-    - name: Set environment variables
-      run: |
-        echo "SPINN_INSTALL_DIR=$PWD/spinnaker_tools_install" >> $GITHUB_ENV
-        echo "SPINN_COMMON_INSTALL_DIR=$PWD/spinn_common_install" >> $GITHUB_ENV
-        echo "FEC_INSTALL_DIR=$PWD/fec_install" >> $GITHUB_ENV
-        echo "SPYNNAKER_INSTALL_DIR=$PWD/spynnaker_install" >> $GITHUB_ENV
-        echo "C_LOGS_DICT=$PWD/spynnaker/pyNN/model_binaries/logs.sqlite3" >> $GITHUB_ENV
-
-
     - name: Checkout SpiNNaker C Dependencies
       uses: SpiNNakerManchester/SupportScripts/actions/install-spinn-deps@main
       with:
@@ -68,24 +59,39 @@ jobs:
       with:
         base-dir: c_models/src
 
-    - name: Build SpiNNaker C dependencies
+    - name: Build SpiNNaker C code
+      env:
+        SPINN_INSTALL_DIR: ${{ github.workspace }}/spinnaker_tools_install
+        SPINN_COMMON_INSTALL_DIR: ${{ github.workspace }}/spinn_common_install
+        FEC_INSTALL_DIR: ${{ github.workspace }}/fec_install
+        SPYNNAKER_INSTALL_DIR: ${{ github.workspace }}/spynnaker_install
+        C_LOGS_DICT: ${{ github.workspace }}/spynnaker/pyNN/model_binaries/logs.sqlite3
+        CFLAGS: -fdiagnostics-color=always
       run: |
         make -C spinnaker_tools install
         make -C spinn_common install
         make -C SpiNNFrontEndCommon/c_common
         make -C sPyNNaker/neural_modelling
         make -C sPyNNaker/neural_modelling install
 
-    - name: Build C code
-      run: make
-      working-directory: c_models
+    - name: Build SpiNNaker C code globally
       env:
+        SPINN_DIRS: ${{ github.workspace }}/spinn_dirs
+        C_LOGS_DICT: ${{ github.workspace }}/spynnaker/pyNN/model_binaries/logs.sqlite3
         CFLAGS: -fdiagnostics-color=always
+      run: |
+        make -C spinnaker_tools install
+        make -C spinn_common install
+        make -C SpiNNFrontEndCommon/c_common
+        make -C sPyNNaker/neural_modelling
+        make -C sPyNNaker/neural_modelling install
 
     - name: Build C code in DEBUG mode
       run: make clean; make SPYNNAKER_DEBUG=DEBUG
       working-directory: c_models
       env:
+        SPINN_DIRS: ${{ github.workspace }}/spinn_dirs
+        C_LOGS_DICT: ${{ github.workspace }}/spynnaker/pyNN/model_binaries/logs.sqlite3
         CFLAGS: -fdiagnostics-color=always
 
     # To be added: Documentation building

c_models/makefiles/Makefile.common

@@ -1,6 +1,4 @@
-ifndef SPYNNAKER_INSTALL_DIR
-    $(error SPYNNAKER_INSTALL_DIR is not set.  Please define SPYNNAKER_INSTALL_DIR (possibly by running "source setup" in the neural_modelling folder within the sPyNNaker source folder))
-endif
+SPYNNAKER_INSTALL_DIR := $(strip $(if $(SPYNNAKER_INSTALL_DIR), $(SPYNNAKER_INSTALL_DIR), $(if $(SPINN_DIRS), $(SPINN_DIRS)/spynnaker_install, $(error SPYNNAKER_INSTALL_DIR or SPINN_DIRS is not set.  Please define SPYNNAKER_INSTALL_DIR or SPINN_DIRS))))
 
 # Work out the top-level project folder
 MAKEFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))

c_models/makefiles/extra.mk

@@ -1,6 +1,4 @@
-ifndef SPYNNAKER_INSTALL_DIR
-    $(error SPYNNAKER_INSTALL_DIR is not set.  Please define SPYNNAKER_INSTALL_DIR (possibly by running "source setup" in the neural_modelling folder within the sPyNNaker source folder))
-endif
+SPYNNAKER_INSTALL_DIR := $(strip $(if $(SPYNNAKER_INSTALL_DIR), $(SPYNNAKER_INSTALL_DIR), $(if $(SPINN_DIRS), $(SPINN_DIRS)/spynnaker_install, $(error SPYNNAKER_INSTALL_DIR or SPINN_DIRS is not set.  Please define SPYNNAKER_INSTALL_DIR or SPINN_DIRS))))
 
 # Work out the top-level project folder
 MAKEFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))

c_models/makefiles/extra_neuron.mk

@@ -1,6 +1,4 @@
-ifndef SPYNNAKER_INSTALL_DIR
-    $(error SPYNNAKER_INSTALL_DIR is not set.  Please define SPYNNAKER_INSTALL_DIR (possibly by running "source setup" in the neural_modelling folder within the sPyNNaker source folder))
-endif
+SPYNNAKER_INSTALL_DIR := $(strip $(if $(SPYNNAKER_INSTALL_DIR), $(SPYNNAKER_INSTALL_DIR), $(if $(SPINN_DIRS), $(SPINN_DIRS)/spynnaker_install, $(error SPYNNAKER_INSTALL_DIR or SPINN_DIRS is not set.  Please define SPYNNAKER_INSTALL_DIR or SPINN_DIRS))))
 
 # Work out the top-level project folder
 MAKEFILE_PATH := $(abspath $(lastword $(MAKEFILE_LIST)))