CS + PHPStan

Author: Spamercz

tests/SpameriTests/Data/Entity/Person.php

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace SpameriTests\Data\Entity;
 
@@ -78,7 +78,7 @@ public function __construct(
 
 	public function entityVariables() : array
 	{
-		return get_object_vars($this);
+		return \get_object_vars($this);
 	}
 
 

tests/SpameriTests/Data/Entity/Person/Character.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 
 namespace SpameriTests\Data\Entity\Person;
 
@@ -57,7 +57,7 @@ public function __construct(
 
 	public function entityVariables() : array
 	{
-		return get_object_vars($this);
+		return \get_object_vars($this);
 	}
 
 

tests/SpameriTests/Data/Entity/Person/CharacterCollectionElastic.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 
 namespace SpameriTests\Data\Entity\Person;
 

tests/SpameriTests/Data/Entity/Person/Job.php

@@ -28,7 +28,7 @@ class Job implements \Spameri\Elastic\Entity\IEntity
 	private $description;
 
 	/**
-	 * @var \SpameriTests\Data\Entity\Property\ImdbId
+	 * @var \SpameriTests\Data\Entity\Property\ImdbId|NULL
 	 */
 	private $episode;
 
@@ -49,7 +49,7 @@ public function __construct(
 
 	public function entityVariables() : array
 	{
-		return get_object_vars($this);
+		return \get_object_vars($this);
 	}
 
 

tests/SpameriTests/Data/Entity/Person/JobCollectionElastic.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 
 namespace SpameriTests\Data\Entity\Person;
 
@@ -16,7 +16,7 @@ public function job(
 			if ($episode) {
 				if (
 					$job->id()->value() === $imdbId->value()
-					&& $job->episode()
+					&& $job->episode() instanceof \SpameriTests\Data\Entity\Property\ImdbId
 					&& $job->episode()->value() === $episode->value()
 				) {
 					return $job;

tests/SpameriTests/Data/Entity/Property/CountryShort.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 
 namespace SpameriTests\Data\Entity\Property;
 

tests/SpameriTests/Data/Entity/Property/Description.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 
 namespace SpameriTests\Data\Entity\Property;
 

tests/SpameriTests/Data/Entity/Property/ElasticIdCollection.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 
 namespace SpameriTests\Data\Entity\Property;
 
@@ -7,7 +7,7 @@ class ElasticIdCollection implements \Spameri\Elastic\Entity\IValueCollection
 {
 
 	/**
-	 * @var \Spameri\Elastic\Entity\Property\IElasticId[]
+	 * @var array<\Spameri\Elastic\Entity\Property\IElasticId>
 	 */
 	private $collection;
 

tests/SpameriTests/Data/Entity/Property/ImdbId.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 
 namespace SpameriTests\Data\Entity\Property;
 

tests/SpameriTests/Data/Entity/Property/ImdbIdCollection.php

@@ -1,4 +1,4 @@
-<?php
+<?php declare(strict_types = 1);
 
 namespace SpameriTests\Data\Entity\Property;
 
@@ -7,7 +7,7 @@ class ImdbIdCollection implements \Spameri\Elastic\Entity\IValueCollection
 {
 
 	/**
-	 * @var \SpameriTests\Data\Entity\Property\ImdbId[]
+	 * @var array<\SpameriTests\Data\Entity\Property\ImdbId>
 	 */
 	private $collection;
 
@@ -53,7 +53,13 @@ public function keys() : array
 
 	public function first() : ?ImdbId
 	{
-		return \reset($this->collection);
+		$first = \reset($this->collection);
+
+		if ($first === FALSE) {
+			throw new \Nette\InvalidStateException();
+		}
+
+		return $first;
 	}