Skip to content

Spacebrew.js doesn't work in node #4

@vorg

Description

@vorg

Beside checking for node environment, module exports and using wc node module the spacebrew.js 1.3.0 doesn't work in node.

#140 - you use window without checking if it's defined (it's not in node)
this.debug = (window.getQueryString('debug') === "true" ? true : (options.debug || false));

#226 - you use browser style this.socket.onopen handlers while ws module requires this.socket.on('open'...

I fixed all that successfully published client on the cloud and then failed because of SyntaxError: Unexpected token u error in incoming message.

Are there plans to officially support node / Plask apps?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions