Coding Standards: Remove redundant ! empty() check in is_object_in_term().

SergeyBiryukov · SergeyBiryukov · commit ee53cb4e204c · 2025-06-05T10:59:30.000Z
If `$object_terms` is empty, the immediately preceding code block causes the function to return early. Follow-up to [8131], [10159]. Props justlevine. See #63268. git-svn-id: https://develop.svn.wordpress.org/trunk@60282 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/taxonomy.php b/src/wp-includes/taxonomy.php
@@ -4898,11 +4898,13 @@ function is_object_in_term( $object_id, $taxonomy, $terms = null ) {
 	if ( is_wp_error( $object_terms ) ) {
 		return $object_terms;
 	}
+
 	if ( empty( $object_terms ) ) {
 		return false;
 	}
+
 	if ( empty( $terms ) ) {
-		return ( ! empty( $object_terms ) );
+		return true;
 	}
 
 	$terms = (array) $terms;

Original file line number	Diff line number	Diff line change
`@@ -4898,11 +4898,13 @@ function is_object_in_term( $object_id, $taxonomy, $terms = null ) {`
`4898`	`4898`	`if ( is_wp_error( $object_terms ) ) {`
`4899`	`4899`	`return $object_terms;`
`4900`	`4900`	`}`
	`4901`	`+`
`4901`	`4902`	`if ( empty( $object_terms ) ) {`
`4902`	`4903`	`return false;`
`4903`	`4904`	`}`
	`4905`	`+`
`4904`	`4906`	`if ( empty( $terms ) ) {`
`4905`		`- return ( ! empty( $object_terms ) );`
	`4907`	`+ return true;`
`4906`	`4908`	`}`
`4907`	`4909`
`4908`	`4910`	`$terms = (array) $terms;`