fix apply bug

Author: mikolalysenko

crates/socket-patch-cli/src/commands/apply.rs

@@ -968,14 +968,16 @@ async fn apply_patches_inner(
     let has_any_purls = !partitioned.is_empty();
 
     if all_packages.is_empty() && !has_any_purls {
+        // Nothing in scope: the manifest lists no patches (or every patch was
+        // filtered out by `--ecosystems`). There is genuinely no work to do,
+        // so this is a clean no-op SUCCESS — not a failure. Returning `false`
+        // here used to exit 1 / `partialFailure`, which broke the npm
+        // `postinstall` hook (it runs `apply` on every install, including
+        // fresh projects whose manifest has no matching patches yet).
         if !args.common.silent && !args.common.json {
-            if args.common.global || args.common.global_prefix.is_some() {
-                eprintln!("No global packages found");
-            } else {
-                eprintln!("No package directories found");
-            }
+            println!("No patches to apply.");
         }
-        return Ok((false, Vec::new(), Vec::new()));
+        return Ok((true, Vec::new(), Vec::new()));
     }
 
     if all_packages.is_empty() {

crates/socket-patch-cli/tests/in_process_edge_cases.rs

@@ -599,12 +599,13 @@ async fn apply_empty_manifest_is_noop() {
     write_manifest(&socket, r#"{ "patches": {} }"#);
 
     let code = apply_run(default_apply(tmp.path())).await;
-    // Empty manifest → no patches in scope → `apply_patches_inner`
-    // returns `success == false`, which maps to exit code 1. This must
-    // be asserted exactly: `code == 0 || code == 1` accepts every
-    // outcome the function can return and would stay green even if the
-    // empty-scope path regressed to a spurious success.
-    assert_eq!(code, 1, "empty manifest is out of scope → exit 1");
+    // Empty manifest → no patches in scope → there is genuinely nothing
+    // to do, so `apply` is a clean no-op SUCCESS (exit 0). This must be
+    // asserted exactly: `code == 0 || code == 1` accepts every outcome the
+    // function can return and would stay green even if the empty-scope path
+    // regressed back to the spurious `partialFailure`/exit-1 that broke the
+    // npm `postinstall` hook (which runs `apply` on every install).
+    assert_eq!(code, 0, "empty manifest has no work → clean no-op success");
     // A true no-op must not invent files. node_modules was never
     // created and the manifest must be untouched on disk.
     assert!(