Commit d7deed9
fix(test): make manifest-unreadable list test cross-platform
`manifest_path_through_regular_file_reports_unreadable_via_binary` nested
the manifest under a regular file (`<file>/manifest.json`), assuming the OS
rejects the read with a non-absence error. That holds on Unix (ENOTDIR) but
NOT on Windows, where traversing through a file is `ERROR_PATH_NOT_FOUND`
(NotFound) — legitimately classified as `manifest_not_found`, failing the
assertion on windows-latest.
Point the manifest path at a directory instead: reading it fails with a
non-NotFound error on every platform (Unix `IsADirectory`, Windows
`PermissionDenied`), so the "present-but-unreadable → manifest_unreadable"
contract is exercised portably. Renamed accordingly.
This was masked on the first push: cargo test is fail-fast and the Windows
run aborted at this binary (sorts before the now-fixed golang/output tests).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent dfe7bbc commit d7deed9
1 file changed
Lines changed: 14 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
392 | 392 | | |
393 | 393 | | |
394 | 394 | | |
395 | | - | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | | - | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
400 | 404 | | |
401 | 405 | | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
406 | 409 | | |
407 | | - | |
408 | | - | |
409 | | - | |
| 410 | + | |
| 411 | + | |
410 | 412 | | |
411 | 413 | | |
412 | 414 | | |
| |||
0 commit comments