Skip to content

Commit 5fde251

Browse files
committed
fix(clippy): allow too_many_arguments on track_patch_scanned
cargo clippy --workspace --all-features -- -D warnings flagged track_patch_scanned at 8/7 args. Grouping the per-tier counts + ecosystems list + fallback flag + auth tuple into a struct would force every call site to build a config object for a single fire-and-forget tracker — worse ergonomics. Annotating the lint is the right call; `track_patch_event` already exists for callers that want full control. Assisted-by: Claude Code:opus-4-7
1 parent 6502824 commit 5fde251

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

crates/socket-patch-core/src/utils/telemetry.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -499,6 +499,13 @@ pub async fn track_patch_rollback_failed(
499499
/// Track a successful `scan`. Reports per-tier patch counts and whether
500500
/// the call was downgraded to the public proxy after an auth-endpoint
501501
/// 401/403 (`fallback_to_proxy`).
502+
///
503+
/// The argument count intentionally mirrors the metadata fields the
504+
/// dashboard needs — grouping them into a struct would force callers
505+
/// to build a config object for a single fire-and-forget call, which
506+
/// is worse ergonomics for a tracker. `track_patch_event` is the
507+
/// general path when you need that flexibility.
508+
#[allow(clippy::too_many_arguments)]
502509
pub async fn track_patch_scanned(
503510
packages_scanned: usize,
504511
free_patches: usize,

0 commit comments

Comments
 (0)