refactor(dlx): rename isNodeJsExtension to isJsFilepath

Author: jdalton

src/dlx/detect.ts

@@ -135,7 +135,6 @@ export function detectLocalExecutableType(
   filePath: string,
 ): ExecutableDetectionResult {
   const fs = getFs()
-  const path = getPath()
 
   // Check 1: Look for package.json with bin field.
   const packageJsonPath = findPackageJson(filePath)
@@ -157,12 +156,11 @@ export function detectLocalExecutableType(
   }
 
   // Check 2: File extension fallback.
-  const ext = path.extname(filePath).toLowerCase()
-  if (NODE_JS_EXTENSIONS.has(ext as '.js' | '.mjs' | '.cjs')) {
+  if (isJsFilePath(filePath)) {
     return {
-      type: 'package',
-      method: 'file-extension',
       inDlxCache: false,
+      method: 'file-extension',
+      type: 'package',
     }
   }
 
@@ -199,12 +197,12 @@ function findPackageJson(filePath: string): string | undefined {
 }
 
 /**
- * Check if a file extension indicates a Node.js script.
+ * Check if a file path indicates a Node.js script.
  *
  * @param filePath - Path to check
  * @returns True if file has .js, .mjs, or .cjs extension
  */
-export function isNodeJsExtension(filePath: string): boolean {
+export function isJsFilePath(filePath: string): boolean {
   const path = getPath()
   const ext = path.extname(filePath).toLowerCase()
   return NODE_JS_EXTENSIONS.has(ext as '.js' | '.mjs' | '.cjs')

test/unit/dlx-detect.test.mts

@@ -5,7 +5,7 @@
  * - detectExecutableType() generic entry point routing
  * - detectDlxExecutableType() detects packages vs binaries in DLX cache
  * - detectLocalExecutableType() detects via package.json and file extensions
- * - isNodeJsExtension() validates .js, .mjs, .cjs extensions
+ * - isJsFilePath() validates .js, .mjs, .cjs file paths
  * - isNodePackage() simplified helper for package detection
  * - isNativeBinary() simplified helper for binary detection
  *
@@ -34,8 +34,8 @@ import {
   detectDlxExecutableType,
   detectExecutableType,
   detectLocalExecutableType,
+  isJsFilePath,
   isNativeBinary,
-  isNodeJsExtension,
   isNodePackage,
 } from '@socketsecurity/lib/dlx/detect'
 import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
@@ -281,33 +281,33 @@ describe('DLX Executable Type Detection', () => {
     })
   })
 
-  describe('isNodeJsExtension', () => {
+  describe('isJsFilePath', () => {
     it('should return true for .js files', () => {
-      expect(isNodeJsExtension('/path/to/file.js')).toBe(true)
-      expect(isNodeJsExtension('file.js')).toBe(true)
+      expect(isJsFilePath('/path/to/file.js')).toBe(true)
+      expect(isJsFilePath('file.js')).toBe(true)
     })
 
     it('should return true for .mjs files', () => {
-      expect(isNodeJsExtension('/path/to/module.mjs')).toBe(true)
-      expect(isNodeJsExtension('module.mjs')).toBe(true)
+      expect(isJsFilePath('/path/to/module.mjs')).toBe(true)
+      expect(isJsFilePath('module.mjs')).toBe(true)
     })
 
     it('should return true for .cjs files', () => {
-      expect(isNodeJsExtension('/path/to/common.cjs')).toBe(true)
-      expect(isNodeJsExtension('common.cjs')).toBe(true)
+      expect(isJsFilePath('/path/to/common.cjs')).toBe(true)
+      expect(isJsFilePath('common.cjs')).toBe(true)
     })
 
     it('should be case-insensitive', () => {
-      expect(isNodeJsExtension('FILE.JS')).toBe(true)
-      expect(isNodeJsExtension('MODULE.MJS')).toBe(true)
-      expect(isNodeJsExtension('COMMON.CJS')).toBe(true)
+      expect(isJsFilePath('FILE.JS')).toBe(true)
+      expect(isJsFilePath('MODULE.MJS')).toBe(true)
+      expect(isJsFilePath('COMMON.CJS')).toBe(true)
     })
 
     it('should return false for non-Node.js extensions', () => {
-      expect(isNodeJsExtension('/path/to/binary')).toBe(false)
-      expect(isNodeJsExtension('/path/to/file.py')).toBe(false)
-      expect(isNodeJsExtension('/path/to/file.sh')).toBe(false)
-      expect(isNodeJsExtension('/path/to/file.exe')).toBe(false)
+      expect(isJsFilePath('/path/to/binary')).toBe(false)
+      expect(isJsFilePath('/path/to/file.py')).toBe(false)
+      expect(isJsFilePath('/path/to/file.sh')).toBe(false)
+      expect(isJsFilePath('/path/to/file.exe')).toBe(false)
     })
   })