refactor: consolidate utilities to use @socketsecurity/lib

Replaced local utility implementations with centralized versions from
@socketsecurity/lib:
- changed-test-mapper.mjs: Use lib git and path utilities
- interactive-runner.mjs: Use lib runWithMask (simplified from 269 to 71 lines)
- run-command.mjs: Use lib spawn with proper error handling
- test.mjs: Use lib getDefaultSpinner

Removed redundant local utility files:
- git.mjs (replaced by @socketsecurity/lib/git)
- path.mjs (replaced by @socketsecurity/lib/path)
- spinner.mjs (replaced by @socketsecurity/lib/spinner)

Benefits:
- Reduced code duplication by 455 lines
- Consistent behavior across all socket-* repositories
- Better error handling with try/catch in run-command.mjs
- Simplified maintenance with centralized utilities

Author: jdalton

scripts/test.mjs

@@ -7,13 +7,16 @@ import { spawn } from 'node:child_process'
 import { existsSync } from 'node:fs'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
+import { getDefaultSpinner } from '@socketsecurity/lib/spinner'
+
 import { getLocalPackageAliases } from './utils/get-local-package-aliases.mjs'
 import { getTestsToRun } from './utils/changed-test-mapper.mjs'
 import { printHeader } from './utils/helpers.mjs'
 import { logger } from './utils/logger.mjs'
 import { parseArgs } from './utils/parse-args.mjs'
 import { onExit } from './utils/signal-exit.mjs'
-import { spinner } from './utils/spinner.mjs'
+
+const spinner = getDefaultSpinner()
 
 const WIN32 = process.platform === 'win32'
 

scripts/utils/changed-test-mapper.mjs

@@ -6,8 +6,11 @@
 import { existsSync } from 'node:fs'
 import path from 'node:path'
 
-import { getChangedFilesSync, getStagedFilesSync } from './git.mjs'
-import { normalizePath } from './path.mjs'
+import {
+  getChangedFilesSync,
+  getStagedFilesSync,
+} from '@socketsecurity/lib/git'
+import { normalizePath } from '@socketsecurity/lib/path'
 
 const rootPath = path.resolve(process.cwd())
 

scripts/utils/git.mjs

@@ -3,13 +3,7 @@
  * Standardized across all socket-* repositories.
  */
 
-import { spawn } from 'node:child_process'
-import readline from 'node:readline'
-
-import { spinner } from './spinner.mjs'
-
-// Will import from registry once built:
-// import { attachOutputMask, clearLine, writeOutput } from '@socketsecurity/lib/stdio/mask'
+import { runWithMask } from '@socketsecurity/lib/stdio/mask'
 
 /**
  * Run a command with interactive output control.
@@ -29,208 +23,16 @@ export async function runWithOutput(command, args = [], options = {}) {
     cwd = process.cwd(),
     env = process.env,
     message = 'Running',
-    showOnError = true,
     toggleText = 'to see output',
     verbose = false,
   } = options
 
-  return new Promise((resolve, reject) => {
-    let isSpinning = false
-    let outputBuffer = []
-    let showOutput = verbose
-    let hasTestFailures = false
-    let hasWorkerTerminationError = false
-
-    // Start spinner if not verbose and TTY
-    if (!showOutput && process.stdout.isTTY) {
-      spinner.start(`${message} (ctrl+o ${toggleText})`)
-      isSpinning = true
-    }
-
-    const child = spawn(command, args, {
-      cwd,
-      env,
-      stdio: ['inherit', 'pipe', 'pipe'],
-    })
-
-    // Setup keyboard handling for TTY
-    if (process.stdin.isTTY && !verbose) {
-      readline.emitKeypressEvents(process.stdin)
-      process.stdin.setRawMode(true)
-
-      const keypressHandler = (_str, key) => {
-        // ctrl+o toggles output
-        if (key?.ctrl && key.name === 'o') {
-          showOutput = !showOutput
-
-          if (showOutput) {
-            // Stop spinner and show buffered output
-            if (isSpinning) {
-              spinner.stop()
-              isSpinning = false
-            }
-
-            // Clear line and show buffer
-            process.stdout.write('\r\x1b[K')
-            if (outputBuffer.length > 0) {
-              console.log('--- Showing output ---')
-              outputBuffer.forEach(line => {
-                process.stdout.write(line)
-              })
-              outputBuffer = []
-            }
-          } else {
-            // Hide output and restart spinner
-            process.stdout.write('\r\x1b[K')
-            if (!isSpinning) {
-              spinner.start(`${message} (ctrl+o ${toggleText})`)
-              isSpinning = true
-            }
-          }
-        }
-        // ctrl+c to cancel
-        else if (key?.ctrl && key.name === 'c') {
-          child.kill('SIGTERM')
-          if (process.stdin.isTTY) {
-            process.stdin.setRawMode(false)
-          }
-          process.exit(130)
-        }
-      }
-
-      process.stdin.on('keypress', keypressHandler)
-
-      // Cleanup on exit
-      child.on('exit', () => {
-        if (process.stdin.isTTY) {
-          process.stdin.setRawMode(false)
-          process.stdin.removeListener('keypress', keypressHandler)
-        }
-      })
-    }
-
-    // Handle stdout
-    if (child.stdout) {
-      child.stdout.on('data', data => {
-        const text = data.toString()
-
-        // Filter out known non-fatal warnings (can appear in stdout too)
-        const isFilteredWarning =
-          text.includes('Terminating worker thread') ||
-          text.includes('Unhandled Rejection') ||
-          text.includes('Object.ThreadTermination') ||
-          text.includes('tinypool@')
-
-        if (isFilteredWarning) {
-          hasWorkerTerminationError = true
-          // Skip these warnings - they're non-fatal cleanup messages
-          // But continue to check for test failures in the same output
-        }
-
-        // Check for test failures in vitest output
-        if (
-          text.includes('FAIL') ||
-          text.match(/Test Files.*\d+ failed/) ||
-          text.match(/Tests\s+\d+ failed/)
-        ) {
-          hasTestFailures = true
-        }
-
-        // Don't write filtered warnings to output
-        if (isFilteredWarning) {
-          return
-        }
-
-        if (showOutput) {
-          process.stdout.write(text)
-        } else {
-          outputBuffer.push(text)
-          // Keep buffer reasonable (last 1000 lines)
-          const lines = outputBuffer.join('').split('\n')
-          if (lines.length > 1000) {
-            outputBuffer = [lines.slice(-1000).join('\n')]
-          }
-        }
-      })
-    }
-
-    // Handle stderr
-    if (child.stderr) {
-      child.stderr.on('data', data => {
-        const text = data.toString()
-        // Filter out known non-fatal warnings
-        const isFilteredWarning =
-          text.includes('Terminating worker thread') ||
-          text.includes('Unhandled Rejection') ||
-          text.includes('Object.ThreadTermination') ||
-          text.includes('tinypool@')
-
-        if (isFilteredWarning) {
-          hasWorkerTerminationError = true
-          // Skip these warnings - they're non-fatal cleanup messages
-          return
-        }
-
-        // Check for test failures
-        if (
-          text.includes('FAIL') ||
-          text.match(/Test Files.*\d+ failed/) ||
-          text.match(/Tests\s+\d+ failed/)
-        ) {
-          hasTestFailures = true
-        }
-
-        if (showOutput) {
-          process.stderr.write(text)
-        } else {
-          outputBuffer.push(text)
-        }
-      })
-    }
-
-    child.on('exit', code => {
-      // Cleanup keyboard if needed
-      if (process.stdin.isTTY && !verbose) {
-        process.stdin.setRawMode(false)
-      }
-
-      // Override exit code if we only have worker termination errors
-      // and no actual test failures
-      let finalCode = code || 0
-      if (code !== 0 && hasWorkerTerminationError && !hasTestFailures) {
-        // This is the known non-fatal worker thread cleanup issue
-        // All tests passed, so return success
-        finalCode = 0
-      }
-
-      if (isSpinning) {
-        if (finalCode === 0) {
-          spinner.success(`${message} completed`)
-        } else {
-          spinner.fail(`${message} failed`)
-          // Show output on error if configured
-          if (showOnError && outputBuffer.length > 0) {
-            console.log('\n--- Output ---')
-            outputBuffer.forEach(line => {
-              process.stdout.write(line)
-            })
-          }
-        }
-      }
-
-      resolve(finalCode)
-    })
-
-    child.on('error', error => {
-      if (process.stdin.isTTY && !verbose) {
-        process.stdin.setRawMode(false)
-      }
-
-      if (isSpinning) {
-        spinner.fail(`${message} error: ${error.message}`)
-      }
-      reject(error)
-    })
+  return runWithMask(command, args, {
+    cwd,
+    env,
+    message,
+    showOutput: verbose,
+    toggleText,
   })
 }