upload all manifests files when running socket scan create --reach (#720)

Author: mtorp

src/commands/scan/handle-create-new-scan.mts

@@ -151,9 +151,14 @@ export async function handleCreateNewScan({
 
     logger.success('Reachability analysis completed successfully')
 
-    scanPaths = reachResult.data?.reachabilityReport
-      ? [reachResult.data.reachabilityReport]
-      : []
+    scanPaths = [
+      ...packagePaths.filter(
+        // Ensure the .socket.facts.json isn't duplicated in case it happened
+        // to be in the scan folder before the analysis was run.
+        p => !p.endsWith(constants.DOT_SOCKET_DOT_FACTS_JSON),
+      ),
+      reachResult.data?.reachabilityReport,
+    ]
     tier1ReachabilityScanId = reachResult.data?.tier1ReachabilityScanId
   }
 

src/commands/scan/perform-reachability-analysis.mts

@@ -85,7 +85,8 @@ export async function performReachabilityAnalysis(
 
     const wasSpinning = !!spinner?.isSpinning
 
-    // Exclude .socket.facts.json from upload.
+    // Exclude any .socket.facts.json files that happen to be
+    // in the scan folder before the analysis was run.
     const filepathsToUpload = packagePaths.filter(
       p => !p.endsWith(constants.DOT_SOCKET_DOT_FACTS_JSON),
     )