Skip to content

Commit e9737d6

Browse files
committed
fix: update @socketbin workflow for trusted publisher
- Remove automatic release trigger (manual dispatch only) - Remove all NODE_AUTH_TOKEN/NPM_TOKEN references - Use OIDC authentication via id-token permission instead - Simplify version determination (no release event handling) Trusted publisher uses GitHub OIDC tokens, no npm token needed.
1 parent df81522 commit e9737d6

File tree

1 file changed

+3
-26
lines changed

1 file changed

+3
-26
lines changed

.github/workflows/publish-socketbin.yml

Lines changed: 3 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ on:
1212
required: false
1313
type: boolean
1414
default: false
15-
release:
16-
types: [published]
1715

1816
jobs:
1917
build-binaries:
@@ -107,11 +105,7 @@ jobs:
107105
- name: Determine version
108106
id: version
109107
run: |
110-
if [[ "${{ github.event_name }}" == "release" ]]; then
111-
VERSION="${{ github.event.release.tag_name }}"
112-
else
113-
VERSION="${{ inputs.version }}"
114-
fi
108+
VERSION="${{ inputs.version }}"
115109
# Remove 'v' prefix if present
116110
VERSION="${VERSION#v}"
117111
echo "version=${VERSION}" >> $GITHUB_OUTPUT
@@ -145,8 +139,6 @@ jobs:
145139
146140
cd packages/binaries/cli-linux-x64
147141
npm publish --provenance --access public
148-
env:
149-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
150142
151143
- name: Generate and publish Linux ARM64
152144
if: ${{ !inputs.dry-run }}
@@ -157,8 +149,6 @@ jobs:
157149
158150
cd packages/binaries/cli-linux-arm64
159151
npm publish --provenance --access public
160-
env:
161-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
162152
163153
- name: Generate and publish macOS x64
164154
if: ${{ !inputs.dry-run }}
@@ -169,8 +159,6 @@ jobs:
169159
170160
cd packages/binaries/cli-darwin-x64
171161
npm publish --provenance --access public
172-
env:
173-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
174162
175163
- name: Generate and publish macOS ARM64
176164
if: ${{ !inputs.dry-run }}
@@ -181,8 +169,6 @@ jobs:
181169
182170
cd packages/binaries/cli-darwin-arm64
183171
npm publish --provenance --access public
184-
env:
185-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
186172
187173
- name: Generate and publish Windows x64
188174
if: ${{ !inputs.dry-run }}
@@ -193,8 +179,6 @@ jobs:
193179
194180
cd packages/binaries/cli-win32-x64
195181
npm publish --provenance --access public
196-
env:
197-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
198182
199183
- name: Generate and publish Windows ARM64
200184
if: ${{ !inputs.dry-run }}
@@ -205,8 +189,6 @@ jobs:
205189
206190
cd packages/binaries/cli-win32-arm64
207191
npm publish --provenance --access public
208-
env:
209-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
210192
211193
- name: Dry run summary
212194
if: ${{ inputs.dry-run }}
@@ -237,11 +219,8 @@ jobs:
237219
- name: Determine version
238220
id: version
239221
run: |
240-
if [[ "${{ github.event_name }}" == "release" ]]; then
241-
VERSION="${{ github.event.release.tag_name }}"
242-
else
243-
VERSION="${{ inputs.version }}"
244-
fi
222+
VERSION="${{ inputs.version }}"
223+
# Remove 'v' prefix if present
245224
VERSION="${VERSION#v}"
246225
echo "version=${VERSION}" >> $GITHUB_OUTPUT
247226
@@ -286,8 +265,6 @@ jobs:
286265
if: ${{ !inputs.dry-run }}
287266
working-directory: src/sea/npm-package
288267
run: npm publish --provenance --access public
289-
env:
290-
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
291268

292269
- name: Dry run summary
293270
if: ${{ inputs.dry-run }}

0 commit comments

Comments
 (0)