Consolidate lint rules

Author: jdalton

.config/rollup.base.config.mjs

@@ -45,10 +45,10 @@ const {
   LATEST,
   ROLLUP_ENTRY_SUFFIX,
   ROLLUP_EXTERNAL_SUFFIX,
-  SLASH_NODE_MODULES_SLASH,
   SHADOW_NPM_BIN,
   SHADOW_NPM_INJECT,
   SHADOW_NPM_PATHS,
+  SLASH_NODE_MODULES_SLASH,
   VENDOR,
   VITEST
 } = constants
@@ -135,10 +135,10 @@ function isAncestorsExternal(id, depStats) {
       return false
     }
     const {
-      version,
       dependencies = {},
       optionalDependencies = {},
-      peerDependencies = {}
+      peerDependencies = {},
+      version
     } = readPackageJsonSync(id.slice(0, nameEnd))
     const range =
       dependencies[name] ??
@@ -234,10 +234,10 @@ export default function baseConfig(extendConfig = {}) {
         const parentNameStart = parentNmIndex + SLASH_NODE_MODULES_SLASH.length
         const parentNameEnd = getPackageNameEnd(parentId, parentNameStart)
         const {
-          version,
           dependencies = {},
           optionalDependencies = {},
-          peerDependencies = {}
+          peerDependencies = {},
+          version
         } = readPackageJsonSync(parentId.slice(0, parentNameEnd))
         const range =
           dependencies[name] ??

.config/rollup.dist.config.mjs

@@ -122,24 +122,28 @@ async function globDtsAndMapFiles(namePattern, srcPath) {
 }
 
 async function moveDtsAndMapFiles(namePattern, srcPath, destPath) {
-  for (const filepath of await globDtsAndMapFiles(namePattern, srcPath)) {
-    await fs.rename(filepath, path.join(destPath, path.basename(filepath)))
-  }
+  await Promise.all(
+    (await globDtsAndMapFiles(namePattern, srcPath)).map(p =>
+      fs.rename(p, path.join(destPath, path.basename(p)))
+    )
+  )
 }
 
 async function removeDtsAndMapFiles(namePattern, srcPath) {
-  for (const filepath of await globDtsAndMapFiles(namePattern, srcPath)) {
-    await fs.rm(filepath)
-  }
+  await Promise.all(
+    (await globDtsAndMapFiles(namePattern, srcPath)).map(p => fs.rm(p))
+  )
 }
 
 async function removeJsFiles(namePattern, srcPath) {
-  for (const filepath of await tinyGlob([`**/${namePattern}.js`], {
-    absolute: true,
-    cwd: srcPath
-  })) {
-    await fs.rm(filepath)
-  }
+  await Promise.all(
+    (
+      await tinyGlob([`**/${namePattern}.js`], {
+        absolute: true,
+        cwd: srcPath
+      })
+    ).map(p => fs.rm(p))
+  )
 }
 
 function resetBin(bin) {
@@ -358,7 +362,9 @@ export default () => {
               (basename === `${CONSTANTS}.js` ||
                 basename === `${INSTRUMENT_WITH_SENTRY}.js`)
             ) {
+              // eslint-disable-next-line no-await-in-loop
               await fs.mkdir(rootDistPath, { recursive: true })
+              // eslint-disable-next-line no-await-in-loop
               await fs.writeFile(
                 path.join(rootDistPath, basename),
                 data.code,

.config/rollup.test.config.mjs

@@ -6,8 +6,8 @@ import { isRelative } from '@socketsecurity/registry/lib/path'
 import baseConfig, { INLINED_PACKAGES } from './rollup.base.config.mjs'
 import constants from '../scripts/constants.js'
 import {
-  isBuiltin,
   getPackageName,
+  isBuiltin,
   normalizeId
 } from '../scripts/utils/packages.js'
 

bin/cli.js

@@ -46,6 +46,7 @@ if (
       if (signalName) {
         process.kill(process.pid, signalName)
       } else if (code !== null) {
+        // eslint-disable-next-line n/no-process-exit
         process.exit(code)
       }
     })

eslint.config.js

@@ -136,21 +136,12 @@ module.exports = [
     ignores: biomeConfig.files.ignore.map(convertIgnorePatternToMinimatch)
   },
   {
-    files: ['**/*.{c,}js'],
-    ...importFlatConfigsForScript.recommended
-  },
-  {
-    files: ['**/*.mjs'],
-    ...importFlatConfigsForModule.recommended
-  },
-  {
-    files: ['src/**/*.ts', 'test/**/*.ts'],
-    ...importFlatConfigsForModule.typescript
-  },
-  {
-    files: ['src/**/*.ts', 'test/**/*.ts'],
+    files: ['**/*.ts'],
+    ...importFlatConfigsForModule.typescript,
     languageOptions: {
+      ...importFlatConfigsForModule.typescript.languageOptions,
       globals: {
+        ...importFlatConfigsForModule.typescript.languageOptions?.globals,
         BufferConstructor: 'readonly',
         BufferEncoding: 'readonly',
         NodeJS: 'readonly',
@@ -160,7 +151,10 @@ module.exports = [
       },
       parser: tsParser,
       parserOptions: {
+        ...importFlatConfigsForModule.typescript.languageOptions?.parserOptions,
         projectService: {
+          ...importFlatConfigsForModule.typescript.languageOptions
+            ?.parserOptions?.projectService,
           allowDefaultProject: [
             'test/*.ts',
             // src/utils/*
@@ -176,13 +170,16 @@ module.exports = [
       }
     },
     linterOptions: {
+      ...importFlatConfigsForModule.typescript.linterOptions,
       reportUnusedDisableDirectives: 'off'
     },
     plugins: {
+      ...importFlatConfigsForModule.typescript.plugins,
       ...sharedPlugins,
       '@typescript-eslint': tsEslint.plugin
     },
     rules: {
+      ...importFlatConfigsForModule.typescript.rules,
       ...sharedRules,
       '@typescript-eslint/array-type': ['error', { default: 'array-simple' }],
       '@typescript-eslint/consistent-type-assertions': [
@@ -212,10 +209,21 @@ module.exports = [
     }
   },
   {
-    files: ['scripts/**/*.{c,}js', 'test/**/*.{c,}js'],
+    files: ['**/*.{c,}js'],
+    ...js.configs.recommended,
+    ...importFlatConfigsForScript.recommended,
     ...nodePlugin.configs['flat/recommended-script'],
+    plugins: {
+      ...js.configs.recommended.plugins,
+      ...importFlatConfigsForScript.recommended.plugins,
+      ...nodePlugin.configs['flat/recommended-script'].plugins,
+      ...sharedPlugins
+    },
     rules: {
+      ...js.configs.recommended.rules,
+      ...importFlatConfigsForScript.recommended.rules,
       ...nodePlugin.configs['flat/recommended-script'].rules,
+      ...sharedRules,
       'n/exports-style': ['error', 'module.exports'],
       'n/no-missing-require': ['off'],
       // The n/no-unpublished-bin rule does does not support non-trivial glob
@@ -240,12 +248,14 @@ module.exports = [
     }
   },
   {
-    files: ['scripts/**/*.{c,}js', 'test/**/*.{c,}js'],
+    files: ['**/*.mjs'],
+    ...importFlatConfigsForModule.recommended,
     plugins: {
+      ...importFlatConfigsForModule.recommended.plugins,
       ...sharedPlugins
     },
     rules: {
-      ...js.configs.recommended.rules,
+      ...importFlatConfigsForModule.recommended.rules,
       ...sharedRules
     }
   }