fix check:lint errors

Author: typicode

src/commands/action/core/github.ts

@@ -1,8 +1,8 @@
 // https://github.com/SocketDev/socket-python-cli/blob/6d4fc56faee68d3a4764f1f80f84710635bdaf05/socketsecurity/core/github.py
-// eslint-disable no-await-in-loop
+/* eslint-disable no-await-in-loop */
 import { Octokit } from '@octokit/rest'
-import { Comment } from './classes'
 
+import { Comment } from './classes'
 import * as SCMComments from './scm_comments'
 
 export class GitHub {
@@ -115,16 +115,16 @@ export class GitHub {
     for (const ignoreComment of comments.ignore) {
       if (
         ignoreComment.body?.includes('SocketSecurity ignore') &&
-        !this.commentReactionExists({
+        !(await this.commentReactionExists({
           commentId: ignoreComment.id
-        })
+        }))
       ) {
         await this.postReaction({ commentId: ignoreComment.id })
       }
     }
   }
 
-  async updateComment({ id, body }: { id: number; body: string }) {
+  async updateComment({ body, id }: { id: number; body: string }) {
     await this.octokit.issues.updateComment({
       owner: this.owner,
       repo: this.repo,
@@ -133,15 +133,15 @@ export class GitHub {
     })
   }
 
-  removeCommentAlerts({ comments }: { comments: SCMComments.SocketComments }) {
+  async removeCommentAlerts({ comments }: { comments: SCMComments.SocketComments }) {
     const securityAlert = comments.security
     if (securityAlert !== undefined) {
       const newBody = SCMComments.processSecurityComment({
         security: comments.security,
         ignore: comments.ignore
       })
-      this.handleIgnoreReactons({ comments })
-      this.updateComment({ id: securityAlert.id, body: newBody })
+      await this.handleIgnoreReactons({ comments })
+      await this.updateComment({ id: securityAlert.id, body: newBody })
     }
   }
 
@@ -155,11 +155,11 @@ export class GitHub {
   }
 
   async addSocketComments({
-    securityComment,
-    overviewComment,
     comments,
+    newOverviewComment,
     newSecurityComment,
-    newOverviewComment
+    overviewComment,
+    securityComment
   }: {
     securityComment: string
     overviewComment: string

src/commands/action/core/index.ts

@@ -1,13 +1,17 @@
 // https://github.com/SocketDev/socket-python-cli/blob/6d4fc56faee68d3a4764f1f80f84710635bdaf05/socketsecurity/core/__init__.py
-// eslint-disable no-await-in-loop
-import { SocketSdk } from '@socketsecurity/sdk'
-import { Diff, FullScan, Issue, Package, Purl } from './classes'
-import type { components, operations } from '@socketsecurity/sdk/types/api.d.ts'
-import ndjson from 'ndjson'
+/* eslint-disable no-await-in-loop */
 import { once } from 'node:events'
 import fs from 'node:fs'
 import path from 'node:path'
 
+import ndjson from 'ndjson'
+
+import { SocketSdk } from '@socketsecurity/sdk'
+
+import { Diff, FullScan, Issue, Package, Purl } from './classes'
+
+import type { components, operations } from '@socketsecurity/sdk/types/api.d.ts'
+
 export class Core {
   socket: SocketSdk
   owner: string
@@ -19,9 +23,9 @@ export class Core {
   > = {}
 
   constructor({
-    socket,
     owner,
-    repo
+    repo,
+    socket
   }: Pick<Core, 'socket' | 'owner' | 'repo' | 'files'>) {
     this.socket = socket
     this.owner = owner
@@ -81,8 +85,8 @@ export class Core {
   }
 
   getSourceData({
-    pkg,
-    packages
+    packages,
+    pkg
   }: {
     pkg: Package
     packages: Record<string, Package>
@@ -139,9 +143,9 @@ export class Core {
   }
 
   async createIssueAlerts({
-    pkg,
     alerts,
-    packages
+    packages,
+    pkg
   }: {
     pkg: Package
     alerts: Record<string, Issue[]>
@@ -210,9 +214,9 @@ export class Core {
   }
 
   compareIssueAlerts({
-    newScanAlerts,
+    alerts,
     headScanAlerts,
-    alerts
+    newScanAlerts
   }: {
     newScanAlerts: Record<string, Issue[]>
     headScanAlerts: Record<string, Issue[]>
@@ -257,10 +261,10 @@ export class Core {
   }
 
   checkAlertCapabilities({
-    pkg,
     capabilities,
+    headPackage,
     packageId,
-    headPackage
+    pkg
   }: {
     pkg: Package
     capabilities: Record<string, string[]>
@@ -295,8 +299,8 @@ export class Core {
   }
 
   compareCapabilities({
-    newPackages,
-    headPackages
+    headPackages,
+    newPackages
   }: {
     newPackages: Record<string, Package>
     headPackages: Record<string, Package>
@@ -351,8 +355,8 @@ export class Core {
   }
 
   async compareSBOMs({
-    newScan,
-    headScan
+    headScan,
+    newScan
   }: {
     newScan: Awaited<ReturnType<Core['getSbomData']>>
     headScan: Awaited<ReturnType<Core['getSbomData']>>
@@ -366,7 +370,7 @@ export class Core {
     const consolidated = new Set()
 
     for (const packageId in newPackages) {
-      const { purl, pkg } = this.createPurl({
+      const { pkg, purl } = this.createPurl({
         packageId,
         packages: newPackages
       })
@@ -389,7 +393,7 @@ export class Core {
     }
 
     for (const packageId in headPackages) {
-      const { purl, pkg } = this.createPurl({
+      const { pkg, purl } = this.createPurl({
         packageId,
         packages: headPackages
       })

src/commands/action/core/messages.ts

@@ -4,15 +4,8 @@ import { Diff, Issue, Purl } from './classes'
 export function createSecurityCommentJSON({ diff }: { diff: Diff }) {
   let scanFailed = false
 
-  if (diff.newAlerts.length === 0) {
-    // FIXME: unreachable code
-    for (const alert of diff.newAlerts) {
-      if (alert.error) {
-        scanFailed = true
-        break
-      }
-    }
-  }
+  // Not porting this code because it's unreachable
+  // https://github.com/SocketDev/socket-python-cli/blob/6d4fc56faee68d3a4764f1f80f84710635bdaf05/socketsecurity/core/messages.py#L13-L18
 
   const output: {
     scanFailed: boolean
@@ -216,7 +209,7 @@ export function securityCommentTemplate(diff: Diff): string {
   md +=
     'To accept the risk, merge this PR and you will not be notified again.\n\n'
   md += '<!-- start-socket-alerts-table -->\n'
-  const { ignoreCommands, nextSteps, mdTable } = createSecurityAlertTable(diff)
+  const { ignoreCommands, mdTable, nextSteps } = createSecurityAlertTable(diff)
   md += mdTable
   md += '<!-- end-socket-alerts-table -->\n\n'
   md += createNextSteps(nextSteps)

src/commands/action/core/scm_comments.ts

@@ -65,8 +65,8 @@ export function parseIgnoreCommand(line: string) {
 
 // Ref: https://github.com/socketdev-demo/javascript-threats/pull/89#issuecomment-2456015512
 export function processSecurityComment({
-  security: securityComment,
-  ignore: ignoreComments
+  ignore: ignoreComments,
+  security: securityComment
 }: Pick<SocketComments, 'security' | 'ignore'>): string {
   const result: string[] = []
   let start = false

src/commands/action/index.ts

@@ -1,14 +1,17 @@
 // https://github.com/SocketDev/socket-python-cli/blob/6d4fc56faee68d3a4764f1f80f84710635bdaf05/socketsecurity/socketcli.py
 import { parseArgs } from 'util'
-import { CliSubcommand } from '../../utils/meow-with-subcommands'
+
+import micromatch from 'micromatch'
 import { simpleGit } from 'simple-git'
+
 import { SocketSdk } from '@socketsecurity/sdk'
-import micromatch from 'micromatch'
-import { getDefaultToken } from '../../utils/sdk'
+
 import { Core } from './core'
 import { GitHub } from './core/github'
-import * as SCMComments from './core/scm_comments'
 import * as Messages from './core/messages'
+import * as SCMComments from './core/scm_comments'
+import { CliSubcommand } from '../../utils/meow-with-subcommands'
+import { getDefaultToken } from '../../utils/sdk'
 
 const socket = new SocketSdk(getDefaultToken()!)
 
@@ -58,7 +61,7 @@ export const action: CliSubcommand = {
     if (scm.checkEventType() === 'comment') {
       console.log('Comment initiated flow')
       const comments = await scm.getCommentsForPR()
-      scm.removeCommentAlerts({ comments })
+      await scm.removeCommentAlerts({ comments })
     } else if (scm.checkEventType() === 'diff') {
       console.log('Push initiated flow')
       const core = new Core({ owner: scm.owner, repo: scm.repo, files, socket })
@@ -92,7 +95,7 @@ export const action: CliSubcommand = {
           console.log('Updated overview comment with no dependencies')
         }
       }
-      scm.addSocketComments({
+      await scm.addSocketComments({
         securityComment,
         overviewComment,
         comments,

src/shadow/arborist/lib/arborist/reify.ts

@@ -4,7 +4,6 @@ import process from 'node:process'
 import semver from 'semver'
 
 import { getManifestData } from '@socketsecurity/registry'
-// eslint-disable-next-line import-x/no-unresolved
 import { arrayUnique } from '@socketsecurity/registry/lib/arrays'
 import { hasOwn } from '@socketsecurity/registry/lib/objects'
 import {