Remove defaults for blocked, critical, etc

Author: jdalton

src/shadow/npm/arborist-helpers.mts

@@ -188,18 +188,7 @@ export async function getAlertsMapFromArborist(
     consolidate: false,
     nothrow: false,
     ...options,
-    filter: toFilterConfig({
-      // Leave 'actions' unassigned so it can be given a default value in
-      // subsequent functions where `options` is passed.
-      // actions: undefined,
-      blocked: true,
-      critical: true,
-      cve: true,
-      existing: false,
-      fixable: false,
-      upgradable: false,
-      ...getOwn(options, 'filter'),
-    }),
+    filter: toFilterConfig(getOwn(options, 'filter')),
   } as GetAlertsMapFromArboristOptions & { filter: AlertFilter }
 
   const needInfoOn = getDetailsFromDiff(arb.diff, {

src/shadow/npm/arborist/lib/arborist/index.mts

@@ -14,7 +14,6 @@ import type {
 } from '../../types.mts'
 
 const {
-  NPM,
   NPX,
   SOCKET_CLI_ACCEPT_RISKS,
   SOCKET_CLI_SAFE_BIN,
@@ -119,7 +118,6 @@ export class SafeArborist extends Arborist {
         ? undefined
         : // Lazily access constants.spinner.
           constants.spinner
-    const isSafeNpm = binName === NPM
     const isSafeNpx = binName === NPX
     const alertsMap = await getAlertsMapFromArborist(this, {
       spinner,
@@ -128,14 +126,10 @@ export class SafeArborist extends Arborist {
           ? {
               actions: ['error'],
               blocked: true,
-              critical: false,
-              cve: false,
               existing: true,
-              fixable: false,
             }
           : {
               existing: isSafeNpx,
-              fixable: !isSafeNpm,
             },
     })
     if (alertsMap.size) {

src/utils/alerts-map.mts

@@ -49,18 +49,7 @@ export async function getAlertsMapFromPurls(
     consolidate: false,
     nothrow: false,
     ...options,
-    filter: toFilterConfig({
-      // Leave 'actions' unassigned so it can be given a default value in
-      // subsequent functions where `options` is passed.
-      // actions: undefined,
-      blocked: true,
-      critical: true,
-      cve: true,
-      existing: false,
-      fixable: false,
-      upgradable: false,
-      ...getOwn(options, 'filter'),
-    }),
+    filter: toFilterConfig(getOwn(options, 'filter')),
   } as GetAlertsMapFromPurlsOptions & { filter: AlertFilter }
 
   const uniqPurls = arrayUnique(purls)
@@ -100,7 +89,6 @@ export async function getAlertsMapFromPurls(
       queryParams: {
         alerts: 'true',
         compact: 'true',
-        //...(opts.filter.fixable ? { fixable: 'true' } : {}),
         ...(Array.isArray(opts.filter.actions)
           ? { actions: opts.filter.actions.join(',') }
           : {}),