Minor code cleanup

Author: jdalton

src/commands/scan/cmd-scan-create.mts

@@ -294,8 +294,7 @@ async function run(
   let updatedInput = false
 
   if (!targets.length && !dryRun && interactive) {
-    const received = await suggestTarget()
-    targets = received ?? []
+    targets = await suggestTarget()
     updatedInput = true
   }
 

src/commands/scan/generate-report.mts

@@ -239,7 +239,7 @@ function createLeaf(
     type: alert.type,
     policy: policyAction,
     url: getSocketDevPackageOverviewUrlFromPurl(art),
-    manifest: art.manifestFiles?.map(obj => obj.file) ?? [],
+    manifest: art.manifestFiles?.map(o => o.file) ?? [],
   }
   return leaf
 }

src/commands/scan/suggest_target.mts

@@ -1,6 +1,6 @@
 import { select } from '@socketsecurity/registry/lib/prompts'
 
-export async function suggestTarget(): Promise<string[] | void> {
+export async function suggestTarget(): Promise<string[]> {
   // We could prefill this with sub-dirs of the current
   // dir ... but is that going to be useful?
   const proceed = await select<boolean>({
@@ -19,7 +19,5 @@ export async function suggestTarget(): Promise<string[] | void> {
       },
     ],
   })
-  if (proceed) {
-    return ['.']
-  }
+  return proceed ? ['.'] : []
 }