Skip to content

Commit ae1a60b

Browse files
committed
fix(smol-builder): correct brotli2c patch line numbers for pristine Node.js v24.10.0
The original patch was only partially applying due to incorrect line numbers.
1 parent 10189f6 commit ae1a60b

File tree

1 file changed

+7
-13
lines changed

1 file changed

+7
-13
lines changed

packages/node-smol-builder/patches/004-socketsecurity_brotli2c_build_v24.10.0.patch

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,35 +17,29 @@
1717
# Brotli-compressed binary data must be output as byte arrays, not string literals.
1818
#
1919
# PATCH CREATION PROCESS:
20-
# This patch was created using git diff against POST-yao-pkg Node.js v24.10.0 source.
20+
# This patch was created using git diff against pristine Node.js v24.10.0 source.
2121
# Steps:
2222
# 1. Clone Node.js v24.10.0
23-
# 2. Apply yao-pkg patches: patch -p1 < node.v24.10.0.cpp.patch
24-
# 3. Modify node.gyp to:
23+
# 2. Modify node.gyp to:
2524
# - Add socket_brotli2c target
2625
# - Add socket_brotli2c_exec variable
2726
# - Modify node_js2c action to use socket_brotli2c_exec
28-
# 4. Generate patch with: git add node.gyp && git diff --cached
29-
# 5. Validate with: git reset --hard && patch -p1 --dry-run < patch-file
30-
#
31-
# CRITICAL: This patch MUST be applied AFTER yao-pkg patches, not to pristine source!
27+
# 3. Generate patch with: git add node.gyp && git diff --cached
28+
# 4. Validate with: git reset --hard && patch -p1 --dry-run < patch-file
3229
#
3330
diff --git a/node.gyp b/node.gyp
34-
index 420d5713..8e9a2c1f 100644
31+
index 420d5713..a9e77596 100644
3532
--- a/node.gyp
3633
+++ b/node.gyp
37-
@@ -433,6 +433,7 @@
34+
@@ -434,6 +434,7 @@
3835
],
3936
'node_mksnapshot_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)node_mksnapshot<(EXECUTABLE_SUFFIX)',
4037
'node_js2c_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)node_js2c<(EXECUTABLE_SUFFIX)',
4138
+ 'socket_brotli2c_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)socket_brotli2c<(EXECUTABLE_SUFFIX)',
4239
'conditions': [
4340
['GENERATOR == "ninja"', {
4441
'node_text_start_object_path': 'src/large_pages/node_text_start.node_text_start.o'
45-
@@ -1023,10 +1024,10 @@
46-
],
47-
'actions': [
48-
{
42+
@@ -1026,7 +1027,7 @@
4943
'action_name': 'node_js2c',
5044
'process_outputs_as_sources': 1,
5145
'inputs': [

0 commit comments

Comments
 (0)