feat(builders): add platform/arch arguments and use socket-lib parseArgs

Changes:
- Update node-smol-builder to accept --platform= and --arch= arguments for cross-compilation
- Replace custom parseArgs functions with @socketsecurity/lib/argv/parse in both builders
- Update publish-socketbin.yml workflow to pass platform/arch to smol builder
- Add IS_WINDOWS constant and use TARGET_PLATFORM/TARGET_ARCH throughout smol builder

Benefits:
- Consistent argument parsing across all builders
- Support for cross-compilation in smol builder (matching SEA builder)
- Reduced code duplication with shared parseArgs utility
- Better validation and error handling from socket-lib parseArgs

Author: jdalton

.github/workflows/publish-socketbin.yml

@@ -129,36 +129,29 @@ jobs:
           restore-keys: |
             node-binary-${{ matrix.platform }}-${{ matrix.arch }}-
 
-      - name: Build binary
-        id: build-binary
+      - name: Build smol Node.js binary
+        id: build-smol
         continue-on-error: true
-        env:
-          # Enable ccache for C++ compilation (Linux/macOS)
-          CC: ${{ matrix.os != 'windows' && 'ccache gcc' || '' }}
-          CXX: ${{ matrix.os != 'windows' && 'ccache g++' || '' }}
-          # Use mold linker for faster linking (Linux only)
-          LDFLAGS: ${{ matrix.os == 'linux' && '-fuse-ld=mold' || '' }}
-          # Use ninja build system if available
-          GYP_GENERATORS: ninja
         run: |
-          pnpm run build --sea -- \
+          echo "Building smol Node.js binary..."
+          pnpm --filter @socketsecurity/node-smol-builder run build -- \
             --platform=${{ matrix.platform }} \
             --arch=${{ matrix.arch }}
 
-      - name: Build binary (fallback with clean rebuild)
-        if: steps.build-binary.outcome == 'failure'
-        env:
-          # Enable ccache for C++ compilation (Linux/macOS)
-          CC: ${{ matrix.os != 'windows' && 'ccache gcc' || '' }}
-          CXX: ${{ matrix.os != 'windows' && 'ccache g++' || '' }}
-          # Use mold linker for faster linking (Linux only)
-          LDFLAGS: ${{ matrix.os == 'linux' && '-fuse-ld=mold' || '' }}
-          # Use ninja build system if available
-          GYP_GENERATORS: ninja
+      - name: Build smol binary (fallback with clean rebuild)
+        if: steps.build-smol.outcome == 'failure'
         run: |
-          echo "Initial build failed, attempting clean rebuild with Node.js..."
-          node packages/node-smol-builder/scripts/build.mjs --clean
-          pnpm run build --sea -- \
+          echo "Initial smol build failed, attempting clean rebuild..."
+          pnpm --filter @socketsecurity/node-smol-builder run build -- \
+            --platform=${{ matrix.platform }} \
+            --arch=${{ matrix.arch }} \
+            --clean
+
+      - name: Build SEA binary
+        id: build-sea
+        run: |
+          echo "Building SEA binary..."
+          pnpm --filter @socketsecurity/node-sea-builder run build -- \
             --platform=${{ matrix.platform }} \
             --arch=${{ matrix.arch }}
 

packages/node-sea-builder/scripts/build.mjs

@@ -30,6 +30,7 @@ import os from 'node:os'
 import path from 'node:path'
 import url from 'node:url'
 
+import { parseArgs } from '@socketsecurity/lib/argv/parse'
 import { WIN32 } from '@socketsecurity/lib/constants/platform'
 import { safeDelete } from '@socketsecurity/lib/fs'
 import { logger } from '@socketsecurity/lib/logger'
@@ -628,45 +629,20 @@ if (typeof require !== 'undefined' && (!require.resolve || !require.resolve.path
   }
 }
 
-/**
- * Parse command-line arguments.
- */
-function parseArgs() {
-  const args = process.argv.slice(2)
-  const options = {}
-
-  for (const arg of args) {
-    if (arg.startsWith('--platform=')) {
-      const platform = arg.split('=')[1]
-      if (platform) {
-        options.platform = platform
-      }
-    } else if (arg.startsWith('--arch=')) {
-      const arch = arg.split('=')[1]
-      if (arch) {
-        options.arch = arch
-      }
-    } else if (arg.startsWith('--node-version=')) {
-      const nodeVersion = arg.split('=')[1]
-      if (nodeVersion) {
-        options.nodeVersion = nodeVersion
-      }
-    } else if (arg.startsWith('--output-dir=')) {
-      const outputDir = arg.split('=')[1]
-      if (outputDir) {
-        options.outputDir = outputDir
-      }
-    }
-  }
-
-  return options
-}
-
 /**
  * Main build function.
  */
 async function main() {
-  const options = parseArgs()
+  // Parse command-line arguments.
+  const { values: options } = parseArgs({
+    options: {
+      arch: { type: 'string' },
+      'node-version': { type: 'string' },
+      'output-dir': { type: 'string' },
+      platform: { type: 'string' },
+    },
+    strict: false,
+  })
 
   logger.log('Socket CLI Self-Executable Builder')
   logger.log('====================================')

packages/node-smol-builder/scripts/build.mjs

@@ -61,6 +61,7 @@ import { dirname, join } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { brotliCompressSync, constants as zlibConstants } from 'node:zlib'
 
+import { parseArgs } from '@socketsecurity/lib/argv/parse'
 import { whichBinSync } from '@socketsecurity/lib/bin'
 import { WIN32 } from '@socketsecurity/lib/constants/platform'
 import { logger } from '@socketsecurity/lib/logger'
@@ -147,12 +148,26 @@ async function execCapture(command, options = {}) {
 }
 
 // Parse arguments.
-const args = process.argv.slice(2)
-const CLEAN_BUILD = args.includes('--clean')
-const RUN_VERIFY = args.includes('--verify')
-const RUN_TESTS = args.includes('--test')
-const RUN_FULL_TESTS = args.includes('--test-full')
-const AUTO_YES = args.includes('--yes') || args.includes('-y')
+const { values } = parseArgs({
+  options: {
+    arch: { type: 'string' },
+    clean: { type: 'boolean' },
+    platform: { type: 'string' },
+    test: { type: 'boolean' },
+    'test-full': { type: 'boolean' },
+    verify: { type: 'boolean' },
+    yes: { type: 'boolean', short: 'y' },
+  },
+  strict: false,
+})
+
+const TARGET_PLATFORM = values.platform || platform()
+const TARGET_ARCH = values.arch || process.arch
+const CLEAN_BUILD = !!values.clean
+const RUN_VERIFY = !!values.verify
+const RUN_TESTS = !!values.test
+const RUN_FULL_TESTS = !!values['test-full'] || !!values.testFull
+const AUTO_YES = !!values.yes
 
 // Configuration
 const NODE_VERSION = 'v24.10.0'
@@ -304,8 +319,9 @@ async function copySocketSecurityBootstrap() {
 }
 
 const CPU_COUNT = cpus().length
-const IS_MACOS = platform() === 'darwin'
-const ARCH = process.arch
+const IS_MACOS = TARGET_PLATFORM === 'darwin'
+const IS_WINDOWS = TARGET_PLATFORM === 'win32'
+const ARCH = TARGET_ARCH
 
 /**
  * Check if Node.js source has uncommitted changes.
@@ -963,7 +979,7 @@ async function main() {
 
   // Check if we can use cached build (skip if --clean).
   if (!CLEAN_BUILD) {
-    const distributionOutputBinary = join(BUILD_DIR, 'out', 'Distribution', platform === 'win32' ? 'node.exe' : 'node')
+    const distributionOutputBinary = join(BUILD_DIR, 'out', 'Distribution', IS_WINDOWS ? 'node.exe' : 'node')
     const distBinary = join(ROOT_DIR, 'dist', 'socket-smol')
 
     // Collect all source files that affect the build.
@@ -1770,7 +1786,7 @@ async function main() {
     '.pkg-cache',
     'v3.5',
   )
-  const targetName = `built-${NODE_VERSION}-${platform()}-${ARCH}${IS_MACOS && ARCH === 'arm64' ? '-signed' : ''}`
+  const targetName = `built-${NODE_VERSION}-${TARGET_PLATFORM}-${ARCH}${IS_MACOS && ARCH === 'arm64' ? '-signed' : ''}`
   const targetPath = join(pkgCacheDir, targetName)
 
   printHeader('Installing to pkg Cache')