Do best practice deferring where possible

Author: jdalton

.config/rollup.base.config.mjs

@@ -37,28 +37,11 @@ const {
   ROLLUP_ENTRY_SUFFIX,
   ROLLUP_EXTERNAL_SUFFIX,
   SLASH_NODE_MODULES_SLASH,
-  VENDOR,
-  babelConfigPath,
-  rootPackageJsonPath,
-  rootPath,
-  rootSrcPath,
-  tsconfigPath
+  VENDOR
 } = constants
 
 const SOCKET_INTEROP = '_socketInterop'
 
-const constantsSrcPath = path.join(rootSrcPath, `${CONSTANTS}.ts`)
-
-const babelConfig = require(babelConfigPath)
-const tsPlugin = require('rollup-plugin-ts')
-const rootPackageJson = require(rootPackageJsonPath)
-
-const {
-  dependencies: pkgDeps,
-  devDependencies: pkgDevDeps,
-  overrides: pkgOverrides
-} = rootPackageJson
-
 const builtinAliases = builtinModules.reduce((o, n) => {
   o[n] = `node:${n}`
   return o
@@ -126,6 +109,25 @@ function isAncestorsExternal(id, depStats) {
 }
 
 export default function baseConfig(extendConfig = {}) {
+  // Lazily access constants props.
+  const {
+    babelConfigPath,
+    rootPackageJsonPath,
+    rootPath,
+    rootSrcPath,
+    tsconfigPath
+  } = constants
+
+  const {
+    dependencies: pkgDeps,
+    devDependencies: pkgDevDeps,
+    overrides: pkgOverrides
+  } = require(rootPackageJsonPath)
+
+  const constantsSrcPath = path.join(rootSrcPath, `${CONSTANTS}.ts`)
+  const babelConfig = require(babelConfigPath)
+  const tsPlugin = require('rollup-plugin-ts')
+
   const depStats = {
     dependencies: { __proto__: null },
     devDependencies: { __proto__: null },

.config/rollup.test.config.mjs

@@ -9,15 +9,12 @@ import {
   normalizeId
 } from '../scripts/utils/packages.js'
 
-const {
-  BABEL_RUNTIME,
-  ROLLUP_EXTERNAL_SUFFIX,
-  SUPPORTS_SYNC_ESM,
-  rootSrcPath
-} = constants
+const { BABEL_RUNTIME, ROLLUP_EXTERNAL_SUFFIX } = constants
 
-export default () =>
-  baseConfig({
+export default () => {
+  // Lazily access constants.rootSrcPath
+  const { rootSrcPath } = constants
+  return baseConfig({
     input: {
       'alert-rules': `${rootSrcPath}/utils/alert/rules.ts`,
       errors: `${rootSrcPath}/utils/errors.ts`,
@@ -35,7 +32,8 @@ export default () =>
         sourcemapDebugIds: true
       }
     ],
-    ...(SUPPORTS_SYNC_ESM
+    // Lazily access constants.SUPPORTS_SYNC_ESM
+    ...(constants.SUPPORTS_SYNC_ESM
       ? {
           external(id_) {
             if (id_.endsWith(ROLLUP_EXTERNAL_SUFFIX) || isBuiltin(id_)) {
@@ -58,3 +56,4 @@ export default () =>
         }
       : {})
   })
+}