Skip to content

Commit 5a0b69e

Browse files
authored
Make updatePackageJsonFromNode return a boolean (#452)
1 parent bb63958 commit 5a0b69e

File tree

1 file changed

+17
-11
lines changed

1 file changed

+17
-11
lines changed

src/utils/arborist-helpers.ts

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -294,28 +294,34 @@ export function updatePackageJsonFromNode(
294294
node: SafeNode,
295295
targetVersion: string,
296296
rangeStyle?: RangeStyle | undefined
297-
) {
297+
): boolean {
298+
let result = false
298299
if (isTopLevel(tree, node)) {
299300
const { name } = node
300301
for (const depField of [
301302
'dependencies',
302303
'optionalDependencies',
303304
'peerDependencies'
304305
]) {
305-
const oldValue = editablePkgJson.content[depField] as
306+
const depObject = editablePkgJson.content[depField] as
306307
| { [key: string]: string }
307308
| undefined
308-
if (oldValue) {
309-
const refRange = oldValue[name]
310-
if (refRange) {
311-
editablePkgJson.update({
312-
[depField]: {
313-
...oldValue,
314-
[name]: applyRange(refRange, targetVersion, rangeStyle)
315-
}
316-
})
309+
if (depObject) {
310+
const oldRange = depObject[name]
311+
if (oldRange) {
312+
const newRange = applyRange(oldRange, targetVersion, rangeStyle)
313+
if (oldRange !== newRange) {
314+
result = true
315+
editablePkgJson.update({
316+
[depField]: {
317+
...depObject,
318+
[name]: newRange
319+
}
320+
})
321+
}
317322
}
318323
}
319324
}
320325
}
326+
return result
321327
}

0 commit comments

Comments
 (0)