Create consistent property type and avoid polymorphic values (#428)

Author: jdalton

src/commands/analytics/cmd-analytics.ts

@@ -106,14 +106,14 @@ async function run(
     },
     {
       nook: true,
-      test: scope === 'org' || repo,
+      test: scope === 'org' || !!repo,
       message: 'When scope=repo, repo name should be set through --repo',
       pass: 'ok',
       fail: 'missing'
     },
     {
       nook: true,
-      test: file === '-' || json || markdown,
+      test: file === '-' || !!json || !!markdown,
       message:
         'The `--file` flag is only valid when using `--json` or `--markdown`',
       pass: 'ok',
@@ -129,7 +129,7 @@ async function run(
     },
     {
       nook: true,
-      test: apiToken,
+      test: !!apiToken,
       message:
         'You need to be logged in to use this command. See `socket login`.',
       pass: 'ok',

src/commands/audit-log/cmd-audit-log.ts

@@ -86,14 +86,14 @@ async function run(
 
   const wasBadInput = handleBadInput(
     {
-      test: orgSlug,
+      test: !!orgSlug,
       message: 'Org name should be the first arg',
       pass: 'ok',
       fail: 'missing'
     },
     {
       nook: true,
-      test: apiToken,
+      test: !!apiToken,
       message:
         'You need to be logged in to use this command. See `socket login`.',
       pass: 'ok',

src/commands/config/cmd-config-set.ts

@@ -68,13 +68,13 @@ async function run(
 
   const wasBadInput = handleBadInput(
     {
-      test: supportedConfigKeys.has(key as keyof LocalConfig) || key === 'test',
+      test: key === 'test' || supportedConfigKeys.has(key as keyof LocalConfig),
       message: 'Config key should be the first arg',
       pass: 'ok',
       fail: key ? 'invalid config key' : 'missing'
     },
     {
-      test: value, // This is a string, empty string is not ok
+      test: !!value, // This is a string, empty string is not ok
       message:
         'Key value should be the remaining args (use `unset` to unset a value)',
       pass: 'ok',

src/commands/config/cmd-config-unset.ts

@@ -62,7 +62,7 @@ async function run(
 
   const wasBadInput = handleBadInput(
     {
-      test: supportedConfigKeys.has(key as keyof LocalConfig) || key === 'test',
+      test: key === 'test' || supportedConfigKeys.has(key as keyof LocalConfig),
       message: 'Config key should be the first arg',
       pass: 'ok',
       fail: key ? 'invalid config key' : 'missing'

src/commands/dependencies/cmd-dependencies.ts

@@ -82,7 +82,7 @@ async function run(
     },
     {
       nook: true,
-      test: apiToken,
+      test: !!apiToken,
       message:
         'You need to be logged in to use this command. See `socket login`.',
       pass: 'ok',

src/commands/diff-scan/cmd-diff-scan-get.ts

@@ -127,7 +127,7 @@ async function run(
     },
     {
       nook: true,
-      test: apiToken,
+      test: !!apiToken,
       message:
         'You need to be logged in to use this command. See `socket login`.',
       pass: 'ok',

src/commands/info/cmd-info.ts

@@ -58,7 +58,7 @@ async function run(
 
   const wasBadInput = handleBadInput(
     {
-      test: rawPkgName,
+      test: !!rawPkgName,
       message: 'Expecting a package name',
       pass: 'ok',
       fail: 'missing'

src/commands/manifest/cmd-manifest-gradle.ts

@@ -124,7 +124,7 @@ async function run(
 
   const wasBadInput = handleBadInput(
     {
-      test: target && target !== '-',
+      test: !!target && target !== '-',
       message: 'The DIR arg is required',
       pass: 'ok',
       fail: target === '-' ? 'stdin is not supported' : 'missing'

src/commands/manifest/cmd-manifest-kotlin.ts

@@ -129,7 +129,7 @@ async function run(
 
   const wasBadInput = handleBadInput(
     {
-      test: target && target !== '-',
+      test: !!target && target !== '-',
       message: 'The DIR arg is required',
       pass: 'ok',
       fail: target === '-' ? 'stdin is not supported' : 'missing'

src/commands/manifest/cmd-manifest-scala.ts

@@ -122,7 +122,7 @@ async function run(
 
   const wasBadInput = handleBadInput(
     {
-      test: target && target !== '-',
+      test: !!target && target !== '-',
       message: 'The DIR arg is required',
       pass: 'ok',
       fail: target === '-' ? 'stdin is not supported' : 'missing'