Skip to content

Commit 249be45

Browse files
committed
fix(cli): point @socketaddon/iocraft file: ref at the template, not gitignored build output
The previous file: ref pointed at `packages/package-builder/build/dev/out/socketaddon-iocraft`, which is gitignored — the directory only exists after running `pnpm --filter package-builder run generate:socketaddon`. In a fresh checkout or git worktree, the path doesn't exist, and pnpm v11.0.0 GA's `verifyDepsBeforeRun: install` default flushed this out: every pnpm-prefixed command pre-flight-installs and trips on `ERR_PNPM_LINKED_PKG_DIR_NOT_FOUND`. Repoint to `packages/package-builder/templates/socketaddon-main`, which IS committed (it's the handlebars-free static template the generator copies into the build output). Same files, byte-identical content: package.json declares @socketaddon/iocraft@1.0.0-pre.0 with the per-platform native addons as optionalDependencies, and the index.mjs does runtime platform detection + require() of the matching .node binary. Tests that depend on the native .node binary still need the per- platform addon to be present (built by the package-builder Rust generation step); that's a separate concern from install-time resolution.
1 parent 487ba3f commit 249be45

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

packages/cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
"@octokit/graphql": "catalog:",
7777
"@octokit/request-error": "catalog:",
7878
"@octokit/rest": "catalog:",
79-
"@socketaddon/iocraft": "file:../package-builder/build/dev/out/socketaddon-iocraft",
79+
"@socketaddon/iocraft": "file:../package-builder/templates/socketaddon-main",
8080
"@socketregistry/hyrious__bun.lockb": "catalog:",
8181
"@socketregistry/indent-string": "catalog:",
8282
"@socketregistry/is-interactive": "catalog:",

pnpm-lock.yaml

Lines changed: 6 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)