Update and cleanup repos command

Author: pvdz

src/commands/repos/cmd-repos-create.ts

@@ -6,10 +6,8 @@ import { logger } from '@socketsecurity/registry/lib/logger'
 import { createRepo } from './create-repo'
 import constants from '../../constants'
 import { commonFlags, outputFlags } from '../../flags'
-import { AuthError } from '../../utils/errors'
 import { meowOrExit } from '../../utils/meow-with-subcommands'
 import { getFlagListOutput } from '../../utils/output-formatting'
-import { getDefaultToken } from '../../utils/sdk'
 
 import type { CliCommandConfig } from '../../utils/meow-with-subcommands'
 
@@ -104,13 +102,6 @@ async function run(
     return
   }
 
-  const apiToken = getDefaultToken()
-  if (!apiToken) {
-    throw new AuthError(
-      'User must be authenticated to run this command. To log in, run the command `socket login` and enter your API key.'
-    )
-  }
-
   await createRepo({
     outputJson: Boolean(cli.flags['json']),
     outputMarkdown: Boolean(cli.flags['markdown']),
@@ -119,7 +110,6 @@ async function run(
     description: String(cli.flags['repoDescription'] || ''),
     homepage: String(cli.flags['homepage'] || ''),
     default_branch: String(cli.flags['defaultBranch'] || ''),
-    visibility: String(cli.flags['visibility'] || 'private'),
-    apiToken
+    visibility: String(cli.flags['visibility'] || 'private')
   })
 }

src/commands/repos/cmd-repos-del.ts

@@ -6,10 +6,8 @@ import { logger } from '@socketsecurity/registry/lib/logger'
 import { deleteRepo } from './delete-repo'
 import constants from '../../constants'
 import { commonFlags } from '../../flags'
-import { AuthError } from '../../utils/errors'
 import { meowOrExit } from '../../utils/meow-with-subcommands'
 import { getFlagListOutput } from '../../utils/output-formatting'
-import { getDefaultToken } from '../../utils/sdk'
 
 import type { CliCommandConfig } from '../../utils/meow-with-subcommands'
 
@@ -74,12 +72,5 @@ async function run(
     return
   }
 
-  const apiToken = getDefaultToken()
-  if (!apiToken) {
-    throw new AuthError(
-      'User must be authenticated to run this command. To log in, run the command `socket login` and enter your API key.'
-    )
-  }
-
-  await deleteRepo(orgSlug, repoName, apiToken)
+  await deleteRepo(orgSlug, repoName)
 }

src/commands/repos/cmd-repos-list.ts

@@ -6,10 +6,8 @@ import { logger } from '@socketsecurity/registry/lib/logger'
 import { listRepos } from './list-repos'
 import constants from '../../constants'
 import { commonFlags, outputFlags } from '../../flags'
-import { AuthError } from '../../utils/errors'
 import { meowOrExit } from '../../utils/meow-with-subcommands'
 import { getFlagListOutput } from '../../utils/output-formatting'
-import { getDefaultToken } from '../../utils/sdk'
 
 import type { CliCommandConfig } from '../../utils/meow-with-subcommands'
 
@@ -96,21 +94,16 @@ async function run(
     return
   }
 
-  const apiToken = getDefaultToken()
-  if (!apiToken) {
-    throw new AuthError(
-      'User must be authenticated to run this command. To log in, run the command `socket login` and enter your API key.'
-    )
-  }
-
   await listRepos({
-    apiToken,
-    outputJson: Boolean(cli.flags['json']),
-    outputMarkdown: Boolean(cli.flags['markdown']),
-    orgSlug,
-    sort: String(cli.flags['sort'] || 'created_at'),
     direction: cli.flags['direction'] === 'asc' ? 'asc' : 'desc',
+    orgSlug,
+    outputKind: cli.flags['json']
+      ? 'json'
+      : cli.flags['markdown']
+        ? 'markdown'
+        : 'print',
     page: Number(cli.flags['page']) || 1,
-    per_page: Number(cli.flags['perPage']) || 30
+    per_page: Number(cli.flags['perPage']) || 30,
+    sort: String(cli.flags['sort'] || 'created_at')
   })
 }

src/commands/repos/cmd-repos-update.ts

@@ -6,10 +6,8 @@ import { logger } from '@socketsecurity/registry/lib/logger'
 import { updateRepo } from './update-repo'
 import constants from '../../constants'
 import { commonFlags, outputFlags } from '../../flags'
-import { AuthError } from '../../utils/errors'
 import { meowOrExit } from '../../utils/meow-with-subcommands'
 import { getFlagListOutput } from '../../utils/output-formatting'
-import { getDefaultToken } from '../../utils/sdk'
 
 import type { CliCommandConfig } from '../../utils/meow-with-subcommands'
 
@@ -106,15 +104,7 @@ async function run(
     return
   }
 
-  const apiToken = getDefaultToken()
-  if (!apiToken) {
-    throw new AuthError(
-      'User must be authenticated to run this command. To log in, run the command `socket login` and enter your API key.'
-    )
-  }
-
   await updateRepo({
-    apiToken,
     outputJson: Boolean(cli.flags['json']),
     outputMarkdown: Boolean(cli.flags['markdown']),
     orgSlug,

src/commands/repos/cmd-repos-view.ts

@@ -6,10 +6,8 @@ import { logger } from '@socketsecurity/registry/lib/logger'
 import { viewRepo } from './view-repo'
 import constants from '../../constants'
 import { commonFlags, outputFlags } from '../../flags'
-import { AuthError } from '../../utils/errors'
 import { meowOrExit } from '../../utils/meow-with-subcommands'
 import { getFlagListOutput } from '../../utils/output-formatting'
-import { getDefaultToken } from '../../utils/sdk'
 
 import type { CliCommandConfig } from '../../utils/meow-with-subcommands'
 
@@ -21,7 +19,12 @@ const config: CliCommandConfig = {
   hidden: false,
   flags: {
     ...commonFlags,
-    ...outputFlags
+    ...outputFlags,
+    repoName: {
+      description: 'The repository to check',
+      default: '',
+      type: 'string'
+    }
   },
   help: (command, config) => `
     Usage
@@ -86,12 +89,9 @@ async function run(
     return
   }
 
-  const apiToken = getDefaultToken()
-  if (!apiToken) {
-    throw new AuthError(
-      'User must be authenticated to run this command. To log in, run the command `socket login` and enter your API key.'
-    )
-  }
-
-  await viewRepo(orgSlug, repoName, apiToken)
+  await viewRepo(
+    orgSlug,
+    repoName,
+    cli.flags['json'] ? 'json' : cli.flags['markdown'] ? 'markdown' : 'print'
+  )
 }

src/commands/repos/create-repo.ts

@@ -1,8 +1,48 @@
 import constants from '../../constants'
 import { handleApiCall, handleUnsuccessfulApiResponse } from '../../utils/api'
-import { setupSdk } from '../../utils/sdk'
+import { AuthError } from '../../utils/errors'
+import { getDefaultToken, setupSdk } from '../../utils/sdk'
 
 export async function createRepo({
+  default_branch,
+  description,
+  homepage,
+  orgSlug,
+  outputJson,
+  outputMarkdown,
+  repoName,
+  visibility
+}: {
+  outputJson: boolean
+  outputMarkdown: boolean
+  orgSlug: string
+  repoName: string
+  description: string
+  homepage: string
+  default_branch: string
+  visibility: string
+}): Promise<void> {
+  const apiToken = getDefaultToken()
+  if (!apiToken) {
+    throw new AuthError(
+      'User must be authenticated to run this command. To log in, run the command `socket login` and enter your API key.'
+    )
+  }
+
+  await createRepoWithToken({
+    apiToken,
+    default_branch,
+    description,
+    homepage,
+    orgSlug,
+    outputJson,
+    outputMarkdown,
+    repoName,
+    visibility
+  })
+}
+
+async function createRepoWithToken({
   apiToken,
   default_branch,
   description,
@@ -43,9 +83,10 @@ export async function createRepo({
     'creating repository'
   )
 
-  if (result.success) {
-    spinner.successAndStop('Repository created successfully')
-  } else {
+  if (!result.success) {
     handleUnsuccessfulApiResponse('createOrgRepo', result, spinner)
+    return
   }
+
+  spinner.successAndStop('Repository created successfully')
 }

src/commands/repos/delete-repo.ts

@@ -1,8 +1,23 @@
 import constants from '../../constants'
 import { handleApiCall, handleUnsuccessfulApiResponse } from '../../utils/api'
-import { setupSdk } from '../../utils/sdk'
+import { AuthError } from '../../utils/errors'
+import { getDefaultToken, setupSdk } from '../../utils/sdk'
 
 export async function deleteRepo(
+  orgSlug: string,
+  repoName: string
+): Promise<void> {
+  const apiToken = getDefaultToken()
+  if (!apiToken) {
+    throw new AuthError(
+      'User must be authenticated to run this command. To log in, run the command `socket login` and enter your API key.'
+    )
+  }
+
+  await deleteRepoWithToken(orgSlug, repoName, apiToken)
+}
+
+async function deleteRepoWithToken(
   orgSlug: string,
   repoName: string,
   apiToken: string
@@ -18,9 +33,10 @@ export async function deleteRepo(
     'deleting repository'
   )
 
-  if (result.success) {
-    spinner.successAndStop('Repository deleted successfully')
-  } else {
+  if (!result.success) {
     handleUnsuccessfulApiResponse('deleteOrgRepo', result, spinner)
+    return
   }
+
+  spinner.successAndStop('Repository deleted successfully')
 }

src/commands/repos/list-repos.ts

@@ -6,38 +6,67 @@ import { logger } from '@socketsecurity/registry/lib/logger'
 
 import constants from '../../constants'
 import { handleApiCall, handleUnsuccessfulApiResponse } from '../../utils/api'
-import { setupSdk } from '../../utils/sdk'
+import { AuthError } from '../../utils/errors'
+import { getDefaultToken, setupSdk } from '../../utils/sdk'
 
 export async function listRepos({
-  apiToken,
   direction,
   orgSlug,
-  outputJson,
-  outputMarkdown,
+  outputKind,
   page,
   per_page,
   sort
 }: {
-  outputJson: boolean
-  outputMarkdown: boolean
+  direction: string
   orgSlug: string
+  outputKind: 'json' | 'markdown' | 'print'
+  page: number
+  per_page: number
   sort: string
+}): Promise<void> {
+  const apiToken = getDefaultToken()
+  if (!apiToken) {
+    throw new AuthError(
+      'User must be authenticated to run this command. To log in, run the command `socket login` and enter your API key.'
+    )
+  }
+
+  await listReposWithToken({
+    apiToken,
+    direction,
+    orgSlug,
+    outputKind,
+    page,
+    per_page,
+    sort
+  })
+}
+
+async function listReposWithToken({
+  apiToken,
+  direction,
+  orgSlug,
+  outputKind,
+  page,
+  per_page,
+  sort
+}: {
+  apiToken: string
   direction: string
-  per_page: number
+  orgSlug: string
+  outputKind: 'json' | 'markdown' | 'print'
   page: number
-  apiToken: string
+  per_page: number
+  sort: string
 }): Promise<void> {
   // Lazily access constants.spinner.
   const { spinner } = constants
 
-  spinner.start('Listing repositories...')
+  spinner.start('Fetching list of repositories...')
 
   const socketSdk = await setupSdk(apiToken)
   const result = await handleApiCall(
     socketSdk.getOrgRepoList(orgSlug, {
-      outputJson,
-      outputMarkdown,
-      orgSlug,
       sort,
       direction,
       per_page,
@@ -51,9 +80,9 @@ export async function listRepos({
     return
   }
 
-  spinner.stop()
+  spinner.stop('Fetch complete.')
 
-  if (outputJson) {
+  if (outputKind === 'json') {
     const data = result.data.results.map(o => ({
       id: o.id,
       name: o.name,