MCPClient hotfix + sanity check for duplicate tools definitions in the Conversation manager

alaa-eddine · alaa-eddine · commit b959857f2cdd · 2025-09-16T12:55:44.000+02:00
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@smythos/sre",
-    "version": "1.5.66",
+    "version": "1.5.67",
     "description": "Smyth Runtime Environment",
     "author": "Alaa-eddine KADDOURI",
     "license": "MIT",
diff --git a/packages/core/src/helpers/Conversation.helper.ts b/packages/core/src/helpers/Conversation.helper.ts
@@ -281,6 +281,8 @@ export class Conversation extends EventEmitter {
         let _content = '';
         const reqMethods = this._reqMethods;
         const toolsConfig = this._toolsConfig;
+        //deduplicate tools
+        toolsConfig.tools = toolsConfig.tools.filter((tool, index, self) => self.findIndex((t) => t.name === tool.name) === index);
         const endpoints = this._endpoints;
         const baseUrl = this._baseUrl;
         const message_id = 'msg_' + randomUUID();
diff --git a/packages/sdk/package.json b/packages/sdk/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@smythos/sdk",
-    "version": "1.1.8",
+    "version": "1.1.9",
     "description": "SRE SDK",
     "keywords": [
         "smythos",
diff --git a/packages/sdk/scripts/templates/Component.ts.tpl b/packages/sdk/scripts/templates/Component.ts.tpl
@@ -10,11 +10,12 @@ import { InputSettings, ComponentInput } from '../../types/SDKTypes';
 {{outputsType}}
 
 {{componentJSDoc}}export function {{componentName}}(settings?: T{{componentName}}Settings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || '{{componentName}}', 
+        name: /*settings?.name || */'{{componentName}}', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/APICall.ts b/packages/sdk/src/Components/generated/APICall.ts
@@ -69,11 +69,12 @@ export type TAPICallOutputs = {
  * Use this component to make an API call
  */
 export function APICall(settings?: TAPICallSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'APICall', 
+        name: /*settings?.name || */'APICall', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/APIOutput.ts b/packages/sdk/src/Components/generated/APIOutput.ts
@@ -22,11 +22,12 @@ export type TAPIOutputOutputs = {
 };
 
 export function APIOutput(settings?: TAPIOutputSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'APIOutput', 
+        name: /*settings?.name || */'APIOutput', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/Await.ts b/packages/sdk/src/Components/generated/Await.ts
@@ -22,11 +22,12 @@ export type TAwaitOutputs = {
 };
 
 export function Await(settings?: TAwaitSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'Await', 
+        name: /*settings?.name || */'Await', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/Classifier.ts b/packages/sdk/src/Components/generated/Classifier.ts
@@ -22,11 +22,12 @@ export type TClassifierOutputs = {
 };
 
 export function Classifier(settings?: TClassifierSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'Classifier', 
+        name: /*settings?.name || */'Classifier', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/ECMASandbox.ts b/packages/sdk/src/Components/generated/ECMASandbox.ts
@@ -20,11 +20,12 @@ export type TECMASandboxOutputs = {
 };
 
 export function ECMASandbox(settings?: TECMASandboxSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'ECMASandbox', 
+        name: /*settings?.name || */'ECMASandbox', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/FTimestamp.ts b/packages/sdk/src/Components/generated/FTimestamp.ts
@@ -20,11 +20,12 @@ export type TFTimestampOutputs = {
 };
 
 export function FTimestamp(settings?: TFTimestampSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'FTimestamp', 
+        name: /*settings?.name || */'FTimestamp', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/GenAILLM.ts b/packages/sdk/src/Components/generated/GenAILLM.ts
@@ -107,11 +107,12 @@ export type TGenAILLMOutputs = {
  * Use this component to generate a responses from an LLM
  */
 export function GenAILLM(settings?: TGenAILLMSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'GenAILLM', 
+        name: /*settings?.name || */'GenAILLM', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/HuggingFace.ts b/packages/sdk/src/Components/generated/HuggingFace.ts
@@ -28,11 +28,12 @@ export type THuggingFaceOutputs = {
 };
 
 export function HuggingFace(settings?: THuggingFaceSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'HuggingFace', 
+        name: /*settings?.name || */'HuggingFace', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/ImageGenerator.ts b/packages/sdk/src/Components/generated/ImageGenerator.ts
@@ -37,11 +37,12 @@ export type TImageGeneratorOutputs = {
 };
 
 export function ImageGenerator(settings?: TImageGeneratorSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'ImageGenerator', 
+        name: /*settings?.name || */'ImageGenerator', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/MCPClient.ts b/packages/sdk/src/Components/generated/MCPClient.ts
@@ -32,11 +32,12 @@ export type TMCPClientOutputs = {
 };
 
 export function MCPClient(settings?: TMCPClientSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'MCPClient', 
+        name: /*settings?.name || */'MCPClient', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/ScrapflyWebScrape.ts b/packages/sdk/src/Components/generated/ScrapflyWebScrape.ts
@@ -35,11 +35,12 @@ export type TScrapflyWebScrapeOutputs = {
  * Use this component to scrape web pages
  */
 export function ScrapflyWebScrape(settings?: TScrapflyWebScrapeSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'ScrapflyWebScrape', 
+        name: /*settings?.name || */'ScrapflyWebScrape', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/ServerlessCode.ts b/packages/sdk/src/Components/generated/ServerlessCode.ts
@@ -40,11 +40,12 @@ export type TServerlessCodeOutputs = {
 };
 
 export function ServerlessCode(settings?: TServerlessCodeSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'ServerlessCode', 
+        name: /*settings?.name || */'ServerlessCode', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);
diff --git a/packages/sdk/src/Components/generated/TavilyWebSearch.ts b/packages/sdk/src/Components/generated/TavilyWebSearch.ts
@@ -39,11 +39,12 @@ export type TTavilyWebSearchOutputs = {
  * Use this component to generate a responses from an LLM
  */
 export function TavilyWebSearch(settings?: TTavilyWebSearchSettings, agent?: Agent) {    
-    const { name, ...settingsWithoutName } = settings || {};
+    //const { name, ...settingsWithoutName } = settings || {};
     const dataObject: any = { 
-        name: settings?.name || 'TavilyWebSearch', 
+        name: /*settings?.name || */'TavilyWebSearch', 
         settings: {
-            ...settingsWithoutName 
+            //...settingsWithoutName 
+            ...settings
         }
     };
     const component = new ComponentWrapper(dataObject, agent);

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@smythos/sre",`
`3`		`- "version": "1.5.66",`
	`3`	`+ "version": "1.5.67",`
`4`	`4`	`"description": "Smyth Runtime Environment",`
`5`	`5`	`"author": "Alaa-eddine KADDOURI",`
`6`	`6`	`"license": "MIT",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@smythos/sdk",`
`3`		`- "version": "1.1.8",`
	`3`	`+ "version": "1.1.9",`
`4`	`4`	`"description": "SRE SDK",`
`5`	`5`	`"keywords": [`
`6`	`6`	`"smythos",`