Skip to content

NSIS uninstall removes only the port-8000 firewall rule #60

@SlyWombat

Description

@SlyWombat

Symptom

`src-tauri/installer-hooks.nsh:90` deletes only `"Case Maker (TCP 8000)"` on uninstall. If the user installed with `/PORT=9000` or any other port, that rule survives the uninstall — leaving stale firewall holes.

Fix options

  1. Write the chosen port to a registry value at install time; read it back at uninstall and delete the matching rule.
  2. Discover all rules with display name prefix `"Case Maker (TCP "` via `netsh advfirewall firewall show rule name=all`, parse, delete each.

Option (1) is more reliable — `netsh` parsing is locale-sensitive.

Source

Architectural review §5.3. Severity: nit.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions