Patch

Author: Prince527GitHub

src/main/kotlin/org/elliotnash/yepspigot/YepPaperPlugin.kt

@@ -24,7 +24,6 @@ class YepPaperPlugin : JavaPlugin(), Listener {
     private val colorCodeRegex = "&[0-9a-fk-orx]".toRegex(RegexOption.IGNORE_CASE)
 
     override fun onEnable() {
-        // Advancement details are optional - plugin works without them
         Bukkit.getPluginManager().registerEvents(this, this)
         Bukkit.getMessenger().registerOutgoingPluginChannel(this, YEP_GENERIC)
         Bukkit.getMessenger().registerOutgoingPluginChannel(this, YEP_ADVANCEMENT)
@@ -50,9 +49,11 @@ class YepPaperPlugin : JavaPlugin(), Listener {
     @EventHandler
     fun onPlayerAdvancement(event: PlayerAdvancementDoneEvent) {
         val advancement = event.advancement
-        val key = advancement.key
         val player = event.player
 
+        // Skip recipe unlocks
+        if (advancement.key.key.startsWith("recipes/")) return
+
         val (frameType, title, description) = getAdvancementInfo(advancement)
 
         val message: String = String.format(
@@ -70,10 +71,33 @@ class YepPaperPlugin : JavaPlugin(), Listener {
 
     private fun getAdvancementInfo(advancement: Advancement): Triple<String, String, String> {
         val defaultTitle = advancement.key.key
-        val defaultDesc = ""
-        
-        // Just use default values - advancement display details are optional
-        return Triple(YEP_ADV_DEFAULT, defaultTitle, defaultDesc)
+        val defaultDesc = " "
+
+        return try {
+            // CraftAdvancement has getDisplay() which returns AdvancementDisplay
+            val displayMethod = advancement.javaClass.getDeclaredMethod("getDisplay")
+            val display = displayMethod.invoke(advancement) ?: return Triple(YEP_ADV_DEFAULT, defaultTitle, defaultDesc)
+
+            val titleMethod = display.javaClass.getMethod("getTitle")
+            val descMethod = display.javaClass.getMethod("getDescription")
+            val frameMethod = display.javaClass.getMethod("getType")
+
+            val title = titleMethod.invoke(display)?.toString() ?: defaultTitle
+            val description = descMethod.invoke(display)?.toString() ?: defaultDesc
+
+            val frame = frameMethod.invoke(display)
+            val frameType = when (frame?.toString()?.uppercase()) {
+                "CHALLENGE" -> YEP_ADV_CHALLENGE
+                "GOAL" -> YEP_ADV_GOAL
+                "TASK" -> YEP_ADV_TASK
+                else -> YEP_ADV_DEFAULT
+            }
+
+            Triple(frameType, title, if (description.isBlank()) " " else description)
+        } catch (e: Exception) {
+            logger.warning("Failed to get advancement info: ${e.javaClass.simpleName}: ${e.message}")
+            Triple(YEP_ADV_DEFAULT, defaultTitle, defaultDesc)
+        }
     }
 
     private fun removeColorCodes(input: String): String {