Update tests to fetch OFMX data

Author: ogrun

.github/workflows/ci.yml

@@ -14,6 +14,8 @@ jobs:
           python-version: "3.12"
       - name: Install
         run: pip install -e .
+      - name: Fetch OFMX sample data
+        run: scripts/fetch_ofmx.sh
       - name: Unit tests
         run: python -m unittest discover -s tests
 

tests/test_cli.py

@@ -8,23 +8,27 @@
 
 from ofmx2pgsql import cli
 
+DATA_ROOT = Path("data/ofmx_lk/isolated")
+OFMX_FILE = DATA_ROOT / "ofmx_lk.ofmx"
+SHAPES_FILE = DATA_ROOT / "ofmx_lk_ofmShapeExtension.xml"
 
 class CliTests(unittest.TestCase):
     def test_build_parser_returns_argparse_parser(self) -> None:
         parser = cli.build_parser()
         self.assertIsInstance(parser, argparse.ArgumentParser)
 
+    @unittest.skipUnless(DATA_ROOT.exists(), "OFMX sample data not available")
     def test_scan_flag_runs(self) -> None:
-        exit_code = cli.main(["scan", "ofmx_lk/isolated"])
+        exit_code = cli.main(["scan", str(DATA_ROOT)])
         self.assertEqual(exit_code, 0)
 
     def test_apply_config_populates_defaults(self) -> None:
         with tempfile.NamedTemporaryFile("w", delete=False) as handle:
             handle.write(
                 "[ofmx2pgsql]\n"
                 "dsn = postgresql://user:pass@localhost:5432/ofmx\n"
-                "ofmx = ofmx_lk/isolated/ofmx_lk.ofmx\n"
-                "shapes = ofmx_lk/isolated/ofmx_lk_ofmShapeExtension.xml\n"
+                "ofmx = data/ofmx_lk/isolated/ofmx_lk.ofmx\n"
+                "shapes = data/ofmx_lk/isolated/ofmx_lk_ofmShapeExtension.xml\n"
                 "apply_migrations = true\n"
                 "schema = custom_schema\n"
             )
@@ -35,10 +39,10 @@ def test_apply_config_populates_defaults(self) -> None:
             args = parser.parse_args(["--config", str(config_path), "import"])
             cli._apply_config(args)
             self.assertEqual(args.dsn, "postgresql://user:pass@localhost:5432/ofmx")
-            self.assertEqual(args.ofmx, Path("ofmx_lk/isolated/ofmx_lk.ofmx"))
+            self.assertEqual(args.ofmx, OFMX_FILE)
             self.assertEqual(
                 args.shapes,
-                Path("ofmx_lk/isolated/ofmx_lk_ofmShapeExtension.xml"),
+                SHAPES_FILE,
             )
             self.assertTrue(args.apply_migrations)
             self.assertEqual(args.schema, "custom_schema")

tests/test_parser.py

@@ -6,33 +6,40 @@
 
 from ofmx2pgsql import parser
 
+DATA_ROOT = Path("data/ofmx_lk/isolated")
+OFMX_FILE = DATA_ROOT / "ofmx_lk.ofmx"
+SHAPES_FILE = DATA_ROOT / "ofmx_lk_ofmShapeExtension.xml"
+HAS_DATA = OFMX_FILE.exists() and SHAPES_FILE.exists()
 
 class ParserTests(unittest.TestCase):
+    @unittest.skipUnless(DATA_ROOT.exists(), "OFMX sample data not available")
     def test_iter_ofmx_files_finds_sample(self) -> None:
-        paths = list(parser.iter_ofmx_files(Path("ofmx_lk/isolated")))
-        self.assertEqual(paths, [Path("ofmx_lk/isolated/ofmx_lk.ofmx")])
+        paths = list(parser.iter_ofmx_files(DATA_ROOT))
+        self.assertEqual(paths, [OFMX_FILE])
 
+    @unittest.skipUnless(HAS_DATA, "OFMX sample data not available")
     def test_iter_airports_reads_first_airport(self) -> None:
-        airports = parser.iter_airports(Path("ofmx_lk/isolated/ofmx_lk.ofmx"))
+        airports = parser.iter_airports(OFMX_FILE)
         first = next(airports)
         self.assertEqual(first.code_id, "LKCB")
         self.assertEqual(first.name, "CHEB")
 
+    @unittest.skipUnless(HAS_DATA, "OFMX sample data not available")
     def test_iter_waypoints_reads_first_point(self) -> None:
-        waypoints = parser.iter_waypoints(Path("ofmx_lk/isolated/ofmx_lk.ofmx"))
+        waypoints = parser.iter_waypoints(OFMX_FILE)
         first = next(waypoints)
         self.assertEqual(first.code_id, "ENITA")
 
+    @unittest.skipUnless(HAS_DATA, "OFMX sample data not available")
     def test_iter_navaids_reads_first_vor(self) -> None:
-        navaids = parser.iter_navaids(Path("ofmx_lk/isolated/ofmx_lk.ofmx"))
+        navaids = parser.iter_navaids(OFMX_FILE)
         first = next(navaids)
         self.assertEqual(first.navaid_type, "VOR")
         self.assertEqual(first.code_id, "OKG")
 
+    @unittest.skipUnless(HAS_DATA, "OFMX sample data not available")
     def test_iter_airspace_shapes_reads_sample(self) -> None:
-        shapes = parser.iter_airspace_shapes(
-            Path("ofmx_lk/isolated/ofmx_lk_ofmShapeExtension.xml")
-        )
+        shapes = parser.iter_airspace_shapes(SHAPES_FILE)
         first = next(shapes)
         self.assertIsNotNone(first.ofmx_id)
         self.assertGreater(len(first.positions), 3)