From 58288bc3673a7f191c80373d0d3fda4fbeae8233 Mon Sep 17 00:00:00 2001 From: Ivan Lieckens Date: Fri, 9 Jan 2026 14:32:03 +0100 Subject: [PATCH 1/2] nullreference + Removed throwing an error and rendering nothing instead for when no ISitecoreRenderingContext is available --- .../TagHelpers/EditingScriptsTagHelper.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Sitecore.AspNetCore.SDK.Pages/TagHelpers/EditingScriptsTagHelper.cs b/src/Sitecore.AspNetCore.SDK.Pages/TagHelpers/EditingScriptsTagHelper.cs index bb22efd..48264e4 100644 --- a/src/Sitecore.AspNetCore.SDK.Pages/TagHelpers/EditingScriptsTagHelper.cs +++ b/src/Sitecore.AspNetCore.SDK.Pages/TagHelpers/EditingScriptsTagHelper.cs @@ -25,13 +25,12 @@ public class EditingScriptsTagHelper : TagHelper /// public override void Process(TagHelperContext context, TagHelperOutput output) { - ISitecoreRenderingContext renderingContext = ViewContext?.HttpContext.GetSitecoreRenderingContext() ?? - throw new NullReferenceException(Resources.Exception_EditingScriptsTagHelperSitecoreRenderingContextNull); + ISitecoreRenderingContext? renderingContext = ViewContext?.HttpContext.GetSitecoreRenderingContext(); output.TagName = string.Empty; string html = string.Empty; - if (renderingContext.Response?.Content?.Sitecore?.Context?.IsEditing ?? false) + if (renderingContext?.Response?.Content?.Sitecore?.Context?.IsEditing ?? false) { EditingContext? editingContext = JsonSerializer.Deserialize(renderingContext.Response?.Content.ContextRawData ?? string.Empty); if (editingContext == null) From 9235a1ed1e8c7a9159337152d660a69eeee5b522 Mon Sep 17 00:00:00 2001 From: Ivan Lieckens Date: Fri, 9 Jan 2026 16:18:27 +0100 Subject: [PATCH 2/2] Fixed Unit tests --- .../TagHelpers/EditingScriptsTagHelperFixture.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Sitecore.AspNetCore.SDK.Pages.Tests/TagHelpers/EditingScriptsTagHelperFixture.cs b/tests/Sitecore.AspNetCore.SDK.Pages.Tests/TagHelpers/EditingScriptsTagHelperFixture.cs index e4084e7..5a2be3a 100644 --- a/tests/Sitecore.AspNetCore.SDK.Pages.Tests/TagHelpers/EditingScriptsTagHelperFixture.cs +++ b/tests/Sitecore.AspNetCore.SDK.Pages.Tests/TagHelpers/EditingScriptsTagHelperFixture.cs @@ -54,7 +54,7 @@ public void Ctor_InvalidArgs_Throws(GuardClauseAssertion guard) [Theory] [AutoNSubstituteData] - public async Task ProcessAsync_NoSitecoreContenxt_ExceptionIsThrown(EditingScriptsTagHelper sut, TagHelperContext tagHelperContext, TagHelperOutput tagHelperOutput) + public async Task ProcessAsync_NoSitecoreContext_EmptyResult(EditingScriptsTagHelper sut, TagHelperContext tagHelperContext, TagHelperOutput tagHelperOutput) { // Arrange ViewContext viewContext = new() @@ -66,10 +66,10 @@ public async Task ProcessAsync_NoSitecoreContenxt_ExceptionIsThrown(EditingScrip sut.ViewContext = viewContext; // Act - Func act = async () => await sut.ProcessAsync(tagHelperContext, tagHelperOutput); + await sut.ProcessAsync(tagHelperContext, tagHelperOutput); // Assert - await act.Should().ThrowAsync(); + tagHelperOutput.Content.GetContent().Should().BeEmpty(); } [Theory]