fix NotShouldPhpdocReturnIfExistTypeHint with multiple errors

Author: Simtel

src/Rule/NotShouldPhpdocReturnIfExistTypeHint.php

@@ -44,7 +44,7 @@ public function processNode(Node $node, Scope $scope): array
             ->getNativeReflection();
 
         $methods = $reflection->getMethods();
-
+        $errors = [];
         foreach ($methods as $method) {
             if (str_starts_with($method->getName(), '__')) {
                 continue;
@@ -64,6 +64,7 @@ public function processNode(Node $node, Scope $scope): array
             $returnTypeName = $returnType->getName();
             $tokens = new TokenIterator($this->phpDocLexer->tokenize($doc));
             $text = $this->parser->parse($tokens);
+
             foreach ($text->getTags() as $tag) {
                 if ($tag->name !== '@return') {
                     continue;
@@ -72,11 +73,12 @@ public function processNode(Node $node, Scope $scope): array
                     $value = $tag->value->type->name;
                     if ($value == $returnTypeName
                         && $reflection->getName() === $method->getBetterReflection()->getLocatedSource()->getName()) {
-                        return ['PhpDoc attribute @return for method ' . $method->getName() . ' can be remove'];
+                        $errors[] ='PhpDoc attribute @return for method ' . $method->getName() . ' can be remove';
                     }
                 }
             }
+
         }
-        return [];
+        return $errors;
     }
 }

tests/Fixture/Return/MethodsWithTypeHintAndReturn.php

@@ -13,4 +13,12 @@ public function someMethod(): bool
     {
         return true;
     }
+
+    /**
+     * @return int
+     */
+    private function getInt(): int
+    {
+        return 0;
+    }
 }

tests/Rules/NotShouldPhpdocReturnIfExistTypeHintTest.php

@@ -18,7 +18,7 @@ class NotShouldPhpdocReturnIfExistTypeHintTest extends RuleTestCase
     /**
      * @inheritDoc
      */
-    protected function getRule(): Rule
+    public function getRule(): Rule
     {
         return new NotShouldPhpdocReturnIfExistTypeHint(
             $this->createReflectionProvider(),
@@ -33,7 +33,11 @@ public function testWithError(): void
             [
                 'PhpDoc attribute @return for method someMethod can be remove',
                 7
-            ]
+            ],
+            [
+                'PhpDoc attribute @return for method getInt can be remove',
+                7
+            ],
         ]);
     }
 }