[3.0]: Installer / Upgrader db differences

[sbulen]

Basic Information

I found some minor differences in the DB between using the installer & upgrader while testing #9120 . I'll log these here, to be addressed after #9120 is merged.

Examples:

• Upgrade has idx_id_spider on smf_log_spider_hits, install doesn't
• Upgrade has idx_log_time on smf_log_spider_hits, install doesn't
• Upgrade has id_subscribe on smf_log_subscribed, install doesn't
• Many indexes have the 191-byte restriction on text fields which aren't required now that we're setting the engine & row type
• Some index names are different in install vs upgrade, e.g., 'filename' vs 'idx_filename' on log_packages
• log_packages actually has a duplicate after an upgrade, e.g., 'filename' & 'idx_filename', on the same column
• Numerous text type differences, e.g., text vs mediumtext on exdates on smf_calendar

Once we have the framework solid, we can loop back & iron out the wrinkles.

Steps to reproduce

1.Install
2.Upgrade
3. Compare the DBs

Expected result

The databases should match - names, lengths, defaults, null options, etc.

Actual result

No response

Version/Git revision

3.0 Alpha 4

Database Engine

All

Database Version

8.4.4

PHP Version

8.4.5

Logs

Additional Information

This makes it easy to compare the DBs to a common (somewhat current...) definition:
https://github.com/sbulen/sjrbTools/blob/master/smf_db_compare.php

If you run upgrader & installer in side by side tabs, you can just scroll & see the differences.