Merge pull request #9128 from sbulen/21_bot_views

[2.1] Bots - reduce topic view updates

Author: jdarwood007

Sources/Display.php

@@ -126,8 +126,14 @@ function Display()
 		$_REQUEST['start'] = 'new';
 	}
 
-	// Add 1 to the number of views of this topic (except for robots).
-	if (!$user_info['possibly_robot'] && (empty($_SESSION['last_read_topic']) || $_SESSION['last_read_topic'] != $topic))
+	// Add 1 to the number of views of this topic (except for guests/bots, per setting).
+	// no_guest_views is stricter, & won't log bots or guests.
+	if (empty($modSettings['no_guest_views']))
+		$check = !$user_info['possibly_robot'];
+	else
+		$check = !$user_info['is_guest'];
+
+	if ($check && (empty($_SESSION['last_read_topic']) || $_SESSION['last_read_topic'] != $topic))
 	{
 		$smcFunc['db_query']('', '
 			UPDATE {db_prefix}topics

Sources/ManageSettings.php

@@ -219,6 +219,10 @@ function ModifyBasicSettings($return_config = false)
 		array('check', 'hitStats'),
 		'',
 
+		// Guest stats.
+		array('check', 'no_guest_views'),
+		'',
+
 		// Option-ish things... miscellaneous sorta.
 		array('check', 'disallow_sendBody'),
 		'',

Themes/default/languages/Help.english.php

@@ -421,6 +421,8 @@
 // argument(s): scripturl
 $helptxt['who_enabled'] = 'This setting allows you to turn on or off the <a href="%1$s?action=who" target="_blank" rel="noopener">Who\'s Online</a> page, which shows who is browsing the forum and what they are doing.';
 
+$helptxt['no_guest_views'] = 'This setting disables incrementing views for guests as well as bots.  Bot activity can cause excessive IO, and is often disguised as guest activity, so this may help during a bot attack.';
+
 $helptxt['recycle_enable'] = '&quot;Recycles&quot; deleted topics and posts to the specified board.';
 
 $helptxt['enableReportPM'] = 'This setting allows your users to report personal messages they receive to the administration team. This may be useful in helping to track down any abuse of the personal messaging system.';

Themes/default/languages/ManageSettings.english.php

@@ -103,6 +103,7 @@
 $txt['timeLoadPageEnable'] = 'Display time taken to create every page';
 $txt['disableHostnameLookup'] = 'Disable hostname lookups';
 $txt['who_enabled'] = 'Enable who\'s online list';
+$txt['no_guest_views'] = 'Disable counting views for guests and bots';
 $txt['meta_keywords'] = 'Meta keywords associated with forum';
 $txt['meta_keywords_note'] = 'For search engines. Leave blank for default.';
 $txt['settings_error'] = 'Warning: Updating of Settings.php failed, the settings cannot be saved.';