Skip to content

Commit 79e4366

Browse files
committed
Increment version and clean up some things
1 parent 6b7bee5 commit 79e4366

File tree

10 files changed

+3
-202
lines changed

10 files changed

+3
-202
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ that the reference increments and decrements are not atomic. The premise is that
88
can be very useful in contexts outside of multithreading, in which atomicity is not needed, being just useless
99
overhead. This is why I tried making my own version of `std::shared_ptr`.
1010

11-
Right now, `shared_ref` doesn't fully conform with the `std::shared_ptr` specification of `C++17`. This is probably
11+
Right now, `shared_ref` doesn't fully conform to the `std::shared_ptr` specification of `C++17`. This is probably
1212
an incomplete list of missing features from my version:
1313

1414
- Not allocator-aware

src/cpp_shared_ref/memory.hpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace sm {
1616
bad_weak_ref(const bad_weak_ref&) noexcept = default;
1717

1818
const char* what() const noexcept override {
19-
return "Shared pointer construction failed, as weak pointer is empty";
19+
return "Shared pointer construction failed, as weak pointer manages no object";
2020
}
2121
};
2222
}
@@ -74,7 +74,6 @@ namespace sm {
7474
ptr = ref.ptr;
7575
block = ref.block;
7676

77-
// We just created a new strong reference
7877
block.base->strong_count++;
7978
}
8079

@@ -634,7 +633,6 @@ namespace sm {
634633
ref.ptr = ptr;
635634
ref.block = block;
636635

637-
// We just created a new strong reference
638636
block.base->strong_count++;
639637
}
640638

src/cpp_shared_ref/version.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
namespace sm {
44
inline constexpr unsigned int VERSION_MAJOR {0u};
5-
inline constexpr unsigned int VERSION_MINOR {2u};
5+
inline constexpr unsigned int VERSION_MINOR {3u};
66
inline constexpr unsigned int VERSION_PATCH {0u};
77
}

tests/perf/memory/saved/massif_shared_ptr.txt

Lines changed: 0 additions & 65 deletions
This file was deleted.

tests/perf/memory/saved/massif_shared_ref.txt

Lines changed: 0 additions & 60 deletions
This file was deleted.

tests/perf/memory/saved/massif_shared_ref_old.txt

Lines changed: 0 additions & 68 deletions
This file was deleted.

tests/perf/speed/saved/asus_shared_ptr.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

tests/perf/speed/saved/asus_shared_ref.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

tests/perf/speed/saved/lenovo_shared_ptr.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

tests/perf/speed/saved/lenovo_shared_ref.txt

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)