Rings and Trinket input

[Nexxxy]

Hi,

your script scans for that items in bags rows below the character items.

But you miss some permutes on rings and trinkets

# Gefäß der krabbelnden Schatten (355)
# trinket1=,id=159610,gem_id=154126,bonus_id=5005/4802/1527/4786,reforge=16

but as you see that row is only trinket1, and your script doesnt generate trinket2 slot.
Same goes for finger1 and finger2.

Greetings

[theoneandlonely]

Hi Nexxy,

hmm, weird, are you running the latest version of the script?
Can you provide an input.txt which produces this behaviour?

[Nexxxy]

# SimC Addon 1.10.7
# 8.0 Note: reforge= is being used as a hacky way to capture item context. This will be changed in 8.1

mage="Nexxyana"
level=120
race=lightforged_draenei
region=eu
server=blackmoore
role=spell
professions=alchemy=150/herbalism=150
talents=1313133
spec=frost

head=,id=159244,bonus_id=5062/1557/4786,reforge=35,azerite_powers=478/30/83
neck=,id=158075,bonus_id=4936/4929/4930/1528,azerite_level=29
shoulder=,id=158035,bonus_id=1562/5140/5382,reforge=28,azerite_powers=478/30/15
back=,id=159294,bonus_id=5008/1552/4784,reforge=16
chest=,id=160614,bonus_id=4822/1477/4786/4775,reforge=3,azerite_powers=483/30/205/13
wrist=,id=158348,gem_id=154126,bonus_id=4780/4802/1517/4786,reforge=16
hands=,id=161350,enchant_id=5932,bonus_id=4798/1497/4784,reforge=3
waist=,id=159262,bonus_id=5009/42/1547/4783,reforge=35
legs=,id=159250,gem_id=153709,bonus_id=4780/4802/1542/4784,reforge=16
feet=,id=158303,gem_id=154126,bonus_id=5007/4802/1547/4784,reforge=35
finger1=,id=158318,enchant_id=5942,gem_id=154126,bonus_id=5007/4802/40/1532/4786,reforge=16
finger2=,id=160645,enchant_id=5942,gem_id=154126,bonus_id=4799/1808/1492/4786,reforge=5
trinket1=,id=160656,bonus_id=4799/1492/4786,reforge=5
trinket2=,id=160651,bonus_id=4799/1492/4786,reforge=5
main_hand=,id=158371,enchant_id=5949,bonus_id=5009/1547/4783,reforge=35

### Gear from Bags
#
#
# Gefäß der krabbelnden Schatten (355)
# trinket1=,id=159610,gem_id=154126,bonus_id=5005/4802/1527/4786,reforge=16
#
# Gefäß der krabbelnden Schatten (355)
# trinket2=,id=159610,gem_id=154126,bonus_id=5005/4802/1527/4786,reforge=16
#
# Muschel des dunklen Flüsterns (355)
# trinket1=,id=159620,gem_id=154126,bonus_id=5007/4802/1527/4786,reforge=16
#
# Muschel des dunklen Flüsterns (355)
# trinket2=,id=159620,gem_id=154126,bonus_id=5007/4802/1527/4786,reforge=16
#
# Stacks of reorigination array based on hidden quest completion
# bfa.reorigination_array_stacks=9

[Nexxxy]

i duplicated the lines for trinket 1 and trinket 2, if you remove the trinket2 lines you will get a different result.

Im on the current version

[theoneandlonely]

Hi Nexxxy,

i only get an error if i remove the trinket1 or trinket2-line from my equipped gear (i guess its ok, should almost never happen that a slot isnt occupied.

However, no matter what i add or remove in the bag-section, the correct amount of permutations is generated:
e.g. in your above case we have theoretically 6 different trinkets => ((n^2)-n)/2 = 15 combinations
2 are duplicates
=> 4 different trinkets => 6 combinations
In my out.simc 6 combinations were correctly generated.
Removing both trinket2= lines in bag-section results in the same output.

It would be different if these trinkets had different stats or bonus_ids. But here all duplicate cases and 1&2 == 2&1 combinations were removed.

Or do i miss sth.?

[Nexxxy]

hm ur right, i re-cloned everything and now
it generates everytime 6 different combinations.
Funny thing is that in my config he should show me the best 3 combinations.

If i use fileNo1 : with all 4 lines of items in bags
then i get 3 results
Generating Baseline: Nexxyana_0 1/3 [===================>] 50764/50764 Mean=15848 Error=0.030% 9.796
Generating Baseline: Nexxyana_1 2/3 [===================>] 49308/49308 Mean=15810 Error=0.030% 9.530
Generating Baseline: Nexxyana_3 3/3 [===================>] 49544/49544 Mean=15861 Error=0.030% 9.555

if i use fileNo2 : with only 2 lines (no duplicate lines with trinket1 and trinket2)
then i get
Generating Baseline: Nexxyana_0 1/2 [===================>] 50325/50325 Mean=15846 Error=0.030% 10.25
Generating Baseline: Nexxyana_3 2/2 [===================>] 48986/48986 Mean=15857 Error=0.030% 9.460

settings are :
default_top_n = {-1: 3,
-2: 25,
-3: 100,
-4: 10000}