Fix issue of 0-length solutions being counted as 1

Author: spaaaacccee

client/src/pages/visualiser/Visualisation.tsx

@@ -269,7 +269,7 @@ export function Visualisation({
     }
   }, [viewport, getAgentPositions, step, setSelection]);
 
-  const noVisualisation = !isLoading && (disablePlayback ? false : !timespan);
+  const noVisualisation = !isLoading && (disablePlayback ? false : false);
 
   // ─── Toggle Fullscreen ───────────────────────────────────────────────
 
@@ -655,7 +655,7 @@ export function Visualisation({
                             name: "Moving",
                             value: proportionOf(
                               getAgentPath(selection.agent),
-                              (p) => p.action !== "w",
+                              (p) => ["u", "d", "l", "r"].includes(p.action),
                             ),
                           },
                           {

client/src/pages/visualiser/proportionOf.tsx

@@ -1,3 +1,4 @@
 export function proportionOf<T>(xs: T[], f: (x: T) => boolean): number {
-  return xs.filter(f).length / xs.length;
+  console.log(xs)
+  return xs.length ? xs.filter(f).length / xs.length : 0;
 }

client/src/pages/visualiser/useSolution.tsx

@@ -103,7 +103,7 @@ function createAgentPositionGetter(
     }
   );
 
-  const bs = paths.map((c) => processAgentSimple(c || "w"));
+  const bs = paths.map((c) => processAgentSimple(c ?? ""));
   const getAgentPosition = memoize(
     (n: number): { action?: string; x: number; y: number }[] => {
       let t = 0;
@@ -113,8 +113,9 @@ function createAgentPositionGetter(
           [pick(last(path), "x", "y")],
           createOffsetMap(createActionMap(t, [bs[n]]), defaultOffsetMap)
         );
-        if (!offset.x && !offset.y) continue;
-        path.push({ ...offset, action: bs[n].seek(t) });
+        if (offset.x || offset.y) {
+          path.push({ ...offset, action: bs[n].seek(t) });
+        }
         t++;
       }
       return path;

client/src/queries/useOngoingSubmissionQuery.ts

@@ -18,7 +18,7 @@ import {
 import { del, post } from "queries/mutation";
 import { json } from "queries/query";
 
-const REFETCH_MS = 1000;
+const REFETCH_MS = 2500;
 
 function mergeArray<T>(
   xs: T[],
@@ -145,6 +145,9 @@ const summaryPageCountQuery = (key?: string | number) => ({
   enabled: !!key,
   refetchInterval: REFETCH_MS,
   staleTime: 0,
+  refetchOnReconnect: false,
+  refetchOnMount: false,
+  refetchOnWindowFocus: false,
 });
 
 const MAX_TASKS = 4;
@@ -164,6 +167,8 @@ const summaryQuery = (key: string | number, i: number = 0) => ({
       -now(),
     ),
   enabled: !!key,
+  staleTime: 0,
+  refetchInterval: REFETCH_MS,
   refetchOnReconnect: false,
   refetchOnMount: false,
   refetchOnWindowFocus: false,

server/src/controllers/solutionPath.ts

@@ -1,7 +1,8 @@
 import { RequestHandler } from "express";
-import { chunk, map, split, zipWith } from "lodash";
-import { OngoingSubmissionSolution, SolutionPath, Submission } from "models";
+import { chunk, map, split } from "lodash";
+import { OngoingSubmissionSolution, SolutionPath } from "models";
 import { Types } from "mongoose";
+import { isDefined } from "utils/isDefined";
 import { encode } from "validator";
 import { z } from "zod";
 
@@ -14,7 +15,7 @@ export const getSolutionPath = async (
 ) => {
   if (source === "ongoing") {
     const data = await OngoingSubmissionSolution.findOne({ _id: id });
-    if (data?.solutions) {
+    if (isDefined(data?.solutions)) {
       return split(data.solutions, "\n");
     }
   } else {

server/src/utils/isDefined.ts

@@ -0,0 +1,3 @@
+export const isDefined = <T>(value: T | undefined | null): value is T => {
+    return value !== undefined && value !== null;
+};

server/src/validation/submissionValidatorWorker.ts

@@ -162,7 +162,7 @@ async function validateGroup({
   const timeStart = now();
   validate({
     domain: { cells, width, height },
-    paths: solutions.map((s) => s || "w"),
+    paths: solutions.map((s) => s ?? ""),
     sources: sources.slice(0, count),
     checks: [
       checkImmediateCollision,
@@ -240,8 +240,7 @@ function logOutcome(
       .value();
     if (mode === "comprehensive" && isInteger(a) && a > 0)
       log.warn(
-        `Errors began on agent ${a}, it's possible that ${
-          a - 1
+        `Errors began on agent ${a}, it's possible that ${a - 1
         } agents constitutes a valid solution.`
       );
     return;
@@ -304,8 +303,7 @@ export async function run(data: SubmissionValidatorData[number]): Promise<{
       (await OngoingSubmissionSolution.findById(submission._id)) ?? {};
 
     log.info(
-      `Validating for ${mapMeta.map_name}-${scenarioMeta.scen_type}-${
-        scenarioMeta.type_id
+      `Validating for ${mapMeta.map_name}-${scenarioMeta.scen_type}-${scenarioMeta.type_id
       }, agent count ${solutions?.length ?? 0}.`
     );