Improve error messaging

Author: spaaaacccee

.vscode/settings.json

@@ -2,4 +2,4 @@
   "vitest.disableWorkspaceWarning": true,
   "typescript.tsdk": "node_modules/typescript/lib",
   "remote.autoForwardPorts": false
-}
+}

bun.lock

@@ -1,4 +1,3 @@
 export function proportionOf<T>(xs: T[], f: (x: T) => boolean): number {
-  console.log(xs)
   return xs.length ? xs.filter(f).length / xs.length : 0;
 }

client/src/hooks/useRoundRobinQueries.ts

@@ -1,2 +1,2 @@
 export const appId = "com.shortestpathlab.tracker";
-export const version = "0.2.24";
+export const version = "0.2.25";

client/src/pages/visualiser/proportionOf.tsx

@@ -76,6 +76,7 @@
     "react-dom": "^18",
     "react-email": "3.0.1",
     "redis-memory-server": "^0.11.0",
+    "serialize-error": "^13.0.1",
     "serve-index": "^1.9.1",
     "sharp": "^0.33.5",
     "string-hash": "^1.1.3",

packages/config/index.ts

@@ -9,6 +9,7 @@ import { log } from "logging";
 import { debounce, has } from "lodash";
 import { diskCached } from "./withDiskCache";
 import { get } from "models/Version";
+import { serializeError } from "serialize-error";
 
 export const toJson = (r: Response) => r.json();
 export const toBlob = (r: Response) => r.blob();
@@ -54,7 +55,8 @@ export function cached<V extends z.ZodType>(
     } catch (e) {
       log.error(e, e)
       res.status(500).json({
-        error: `Error occurred: ${e}`,
+        error: `Error occurred retrieving data.`,
+        details: serializeError(e)
       });
     }
   }) as RequestHandler<unknown>;
@@ -77,9 +79,9 @@ export const queryClient = <T>(model: Model<T>) => {
       try {
         res.json(await g(data));
       } catch (e) {
-        log.error(e, e)
         res.status(500).json({
-          error: `Error occurred in ${model.modelName} query handler: ${e}`,
+          error: `Error occurred processing query for ${model.modelName}.`,
+          details: serializeError(e),
         });
       }
     };
@@ -186,7 +188,8 @@ export const route = <T extends z.ZodType, R>(
       log.error("Query error", { message: has(e, "message") ? e.message : e });
       console.error(e);
       res.status(500).json({
-        error: e,
+        error: `Error occurred processing this request.`,
+        details: serializeError(e),
       });
     }
   };

server/package.json

@@ -11,40 +11,42 @@ export const usingWorkerReusable = <R>(w: WorkerConstructor) => {
 
 export const usingWorker =
   <R>(w: WorkerConstructor) =>
-  async (task: (w: Worker) => Promise<R>) => {
-    const worker = w();
-    const out = await task(worker);
-    worker.terminate();
-    return out;
-  };
+    async (task: (w: Worker) => Promise<R>) => {
+      const worker = w();
+      try {
+        return await task(worker);
+      } finally {
+        worker.terminate();
+      }
+    };
 
 const createWorkerTaskFunction =
   (u = usingWorker) =>
-  <T, R>(w: WorkerConstructor) => {
-    const usingW = once(() => u<R>(w));
-    return (inp: T) =>
-      usingW()(
-        (worker) =>
-          new Promise<R>((res, rej) => {
-            const id = randomUUIDv7();
-            worker.postMessage({ data: inp, id });
-            const f = (out: MessageEvent<MessageHandlerResult<R>>) => {
-              if (out.data.id === id) {
-                worker.removeEventListener("message", f);
-                if (out.data.status === "success") res(out.data.result);
-                else rej(out.data.error);
-              }
-            };
-            worker.addEventListener("message", f);
-            worker.addEventListener("error", (e) => {
-              log.error("Worker error", { message: e.message });
-              console.error(e);
-              // Do not reject on error, this listener listens to general worker errors, which may not indicate the current task failing.
-              // Task fails should result in a message that looks like { error: ErrorMessage }.
-            });
-          })
-      );
-  };
+    <T, R>(w: WorkerConstructor) => {
+      const usingW = once(() => u<R>(w));
+      return (inp: T) =>
+        usingW()(
+          (worker) =>
+            new Promise<R>((res, rej) => {
+              const id = randomUUIDv7();
+              worker.postMessage({ data: inp, id });
+              const f = (out: MessageEvent<MessageHandlerResult<R>>) => {
+                if (out.data.id === id) {
+                  worker.removeEventListener("message", f);
+                  if (out.data.status === "success") res(out.data.result);
+                  else rej(out.data.error);
+                }
+              };
+              worker.addEventListener("message", f);
+              worker.addEventListener("error", (e) => {
+                log.error("Worker error", { message: e.message });
+                console.error(e);
+                // Do not reject on error, this listener listens to general worker errors, which may not indicate the current task failing.
+                // Task fails should result in a message that looks like { error: ErrorMessage }.
+              });
+            })
+        );
+    };
 
 export const usingWorkerTask = createWorkerTaskFunction(usingWorker);
 
@@ -57,11 +59,11 @@ type MessageHandlerResult<U> =
 
 export const usingTaskMessageHandler =
   <T, U>(f: (a: T) => Promise<U>) =>
-  async (m: MessageEvent<{ id: string; data: T }>) => {
-    try {
-      const output = await f(m.data.data);
-      postMessage({ status: "success", result: output, id: m.data.id });
-    } catch (e) {
-      postMessage({ status: "error", error: e, id: m.data.id });
-    }
-  };
+    async (m: MessageEvent<{ id: string; data: T }>) => {
+      try {
+        const output = await f(m.data.data);
+        postMessage({ status: "success", result: output, id: m.data.id });
+      } catch (e) {
+        postMessage({ status: "error", error: e, id: m.data.id });
+      }
+    };