From 70d22010f206ea55cc43047795924b64d4da51af Mon Sep 17 00:00:00 2001 From: Neo Khuat Date: Tue, 23 Apr 2019 16:50:22 +0700 Subject: [PATCH 1/2] Update workshop.md --- workshop.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/workshop.md b/workshop.md index d2d69a5..a092eff 100644 --- a/workshop.md +++ b/workshop.md @@ -151,7 +151,7 @@ import createShopifyAuth from '@shopify/koa-shopify-auth'; _server/index.js_ -We can mount our middlware by adding the following lines after we intialize our new Koa app. +We can mount our middleware by adding the following lines after we intialize our new Koa app. ```js app.use(session(app)); From ef93a9878e0c9df74e2ea5dbb8ff9f4e147e7409 Mon Sep 17 00:00:00 2001 From: Neo Khuat Date: Tue, 23 Apr 2019 17:10:20 +0700 Subject: [PATCH 2/2] Update workshop.md --- workshop.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/workshop.md b/workshop.md index a092eff..64b3022 100644 --- a/workshop.md +++ b/workshop.md @@ -219,7 +219,7 @@ Oauth error invalid_request: The redirect_uri is not whitelisted To solve this we need to login to our partners dashboard, go to our App Info and add `YOUR_HTTPS_NGROK_URL/auth/callback` to "Whitelisted redirection URL(s)" textarea. -Now if you try to authenicate again, (`YOUR_HTTPS_NGROK_URL/auth?shop=YOUR_SHOP_DOMAIN`) it should take you to install the app in the Shopify admin. Once its installed you can verify it shows by going to to `YOUR_SHOPIFY_URL/admin/apps`. +Now if you try to authenicate again, (`YOUR_HTTPS_NGROK_URL/auth?shop=YOUR_SHOP_DOMAIN`) it should take you to install the app in the Shopify admin. Once its installed you can verify it shows by going to `YOUR_SHOPIFY_URL/admin/apps`. We now have an authentication route, but users can still go straight to our index without logging in. You can verifiy this by clearing your cookies or loading the your ngrok url in an icognito tab. The next step will protect our `Hello Unite` with a verification middleware. @@ -397,7 +397,7 @@ _app/App.js_ Unfortunately, this code won't actually work yet. -This is due to the fact that we are missing one crucial piece of a modern web app; client side Javascript. We will need to be able run our React code in the browser to rectify this. +This is due to the fact that we are missing one crucial piece of a modern web app: client side Javascript. We will need to be able run our React code in the browser to rectify this. #### Step 3: React in the Browser @@ -640,7 +640,7 @@ _app/App.js_ We want to call our mutation when a game's `Create Product` button is clicked. We can do this by passing a function into the `onAddGame` prop of our `` component. Our ``'s `onAddGame` callback is passed the name of the clicked game. -We can pass this along to our `createProduct` mutation function as the `title`, along with a `productType` of "borad game". +We can pass this along to our `createProduct` mutation function as the `title`, along with a `productType` of "board game". ```js