Address PR review feedback for rename boundary fix

Use indexOf for test positions instead of hardcoded numbers, clarify
comment about @param keyword/type annotation exclusion, and expand
negative tests to cover @param keyword and space before param name.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: charlespwd

packages/theme-language-server-common/src/rename/providers/LiquidVariableRenameProvider.spec.ts

@@ -159,7 +159,7 @@ describe('LiquidVariableRenameProvider', () => {
     it('returns new name when cursor is at first character of liquid doc param name', async () => {
       const params = {
         textDocument,
-        position: Position.create(0, 25),
+        position: Position.create(0, documentSource.indexOf('food')),
         newName: 'meal',
       };
 
@@ -181,6 +181,17 @@ describe('LiquidVariableRenameProvider', () => {
       );
     });
 
+    it('does not trigger rename when cursor is on type annotation', async () => {
+      const params = {
+        textDocument,
+        position: Position.create(0, documentSource.indexOf('{string}') + 1),
+        newName: 'meal',
+      };
+
+      const result = await provider.rename(params);
+      expect(result).to.be.null;
+    });
+
     it('returns new name after liquid doc param is renamed on variable usage', async () => {
       const params = {
         textDocument,
@@ -354,7 +365,7 @@ describe('LiquidVariableRenameProvider', () => {
       it('returns new name when cursor is at first character of untyped param name', async () => {
         const params = {
           textDocument,
-          position: Position.create(0, 16),
+          position: Position.create(0, documentSource.indexOf('prod')),
           newName: 'ppp',
         };
         const result = await provider.rename(params);
@@ -372,15 +383,27 @@ describe('LiquidVariableRenameProvider', () => {
         );
       });
 
-      it('does not trigger rename when cursor is at @ symbol position', async () => {
-        const params = {
-          textDocument,
-          position: Position.create(0, 9),
-          newName: 'ppp',
-        };
+      [
+        { desc: 'at @ symbol', position: Position.create(0, documentSource.indexOf('@param')) },
+        {
+          desc: 'at @param keyword',
+          position: Position.create(0, documentSource.indexOf('@param') + 1),
+        },
+        {
+          desc: 'at space before param name',
+          position: Position.create(0, documentSource.indexOf('@param') + '@param'.length),
+        },
+      ].forEach(({ desc, position }) => {
+        it(`does not trigger rename when cursor is ${desc}`, async () => {
+          const params = {
+            textDocument,
+            position,
+            newName: 'ppp',
+          };
 
-        const result = await provider.rename(params);
-        expect(result).to.be.null;
+          const result = await provider.rename(params);
+          expect(result).to.be.null;
+        });
       });
 
       it('returns new name after variable is renamed inside loop, but is scoped outside it', async () => {

packages/theme-language-server-common/src/rename/providers/LiquidVariableRenameProvider.ts

@@ -80,7 +80,7 @@ export class LiquidVariableRenameProvider implements BaseRenameProvider {
     if (document.ast instanceof Error) return null;
     if (!supportedTags(node, ancestors)) return null;
 
-    // When node is a LiquidDocParamNode, ensure cursor is on the param name, not the @ prefix
+    // When node is a LiquidDocParamNode, ensure cursor is on the param name, not the @param keyword or type annotation
     if (node.type === NodeTypes.LiquidDocParamNode) {
       const cursorOffset = textDocument.offsetAt(params.position);
       const nameEnd = node.paramName.position.start + node.paramName.value.length;