The tapioca-generated rbi shim for prism v1.7.0 results in sorbet errors

[dduugg]

Using the latest tapioca and sorbet releases:

sorbet/rbi/gems/prism@1.7.0.rbi:20832: Cannot initialize the class Parser35 by constant assignment https://srb.help/4022
       20832 |Prism::Translation::Parser35 = Prism::Translation::Parser40
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    sorbet/rbi/gems/prism@1.7.0.rbi:20833: Previously defined as a class here
       20833 |class Prism::Translation::Parser35 < Prism::Translation::Parser; end
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  Note:
    Sorbet does not allow treating constant assignments as class or module definitions,
    even if the initializer computes a Module object at runtime. See the docs for more.
Errors: 1

Reproduced in a public repo here: dduugg/yard-sorbet#384

See: https://github.com/dduugg/yard-sorbet/actions/runs/20416294489/job/58660421072

(Reported in #tapioca in the sorbet slack, pasting here for ease of tracking & search)

[amomchilov]

This only started in this version because Parser35 was defined as an alias to Parser40 (due to the surprise 4.0 naming). Previous versions never did that, so it wasn't an issue.

I'm not sure what the best way to handle this is. Perhaps we can detect this case and emit it as a T.type_alias?

[KaanOzkan]

This particular case is fixed in Prism ruby/prism#3821, we'll have to wait for a release.

This might be an issue in general when the Ruby code (not an imported RBI) contains both of the definitions, I'll have to take a look. If that's the case we can try to fix one of the 2 definitions like @amomchilov mentioned.

[KaanOzkan]

Local testing shows tapioca handles it correctly when both the alias and the class definition is in the Ruby code

tapioca/lib/tapioca/gem/pipeline.rb

Lines 269 to 273 in 0da5886

	if name_of(constant) != symbol
	compile_alias(symbol, constant)
	else
	compile_module(symbol, constant)
	end

I think it's good to fail instead of recover the import rbi/ case as the exported RBIs should be updated like in prism/. I'll close this issue since tapioca is doing the right thing.