From e9f1315d360d104baeed097c2b4ddbd1202da13d Mon Sep 17 00:00:00 2001 From: Vinicius Gama Date: Tue, 28 Jul 2020 16:00:28 -0300 Subject: [PATCH 1/3] Expose issue with a test --- test/unit/deploy_serializer_test.rb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 test/unit/deploy_serializer_test.rb diff --git a/test/unit/deploy_serializer_test.rb b/test/unit/deploy_serializer_test.rb new file mode 100644 index 000000000..fa69e1f52 --- /dev/null +++ b/test/unit/deploy_serializer_test.rb @@ -0,0 +1,17 @@ +# frozen_string_literal: true +require 'test_helper' + +module Shipit + class DeploySerializerTest < ActiveSupport::TestCase + test 'includes author object' do + deploy = shipit_deploys(:shipit) + first_commit_author = deploy.commits.first.author + + serializer = ActiveModel::Serializer.serializer_for(deploy) + assert_equal DeploySerializer, serializer + serialized = serializer.new(deploy).to_json + + assert_json("commits.0.author.name", first_commit_author.name, document: serialized) + end + end +end From e39b6ed77cfe117ab50a78ee51abb466745272b3 Mon Sep 17 00:00:00 2001 From: Vinicius Gama Date: Tue, 28 Jul 2020 16:27:40 -0300 Subject: [PATCH 2/3] Test for commit serialization --- test/unit/commit_serializer_test.rb | 16 ++++++++++++++++ test/unit/deploy_serializer_test.rb | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 test/unit/commit_serializer_test.rb diff --git a/test/unit/commit_serializer_test.rb b/test/unit/commit_serializer_test.rb new file mode 100644 index 000000000..befada120 --- /dev/null +++ b/test/unit/commit_serializer_test.rb @@ -0,0 +1,16 @@ +# frozen_string_literal: true +require 'test_helper' + +module Shipit + class DeploySerializerTest < ActiveSupport::TestCase + test 'commit includes author object' do + commit = shipit_commits(:first) + + serializer = ActiveModel::Serializer.serializer_for(commit) + assert_equal CommitSerializer, serializer + serialized = serializer.new(commit).to_json + + assert_json("author.name", commit.author.name, document: serialized) + end + end +end diff --git a/test/unit/deploy_serializer_test.rb b/test/unit/deploy_serializer_test.rb index fa69e1f52..d15be9fa2 100644 --- a/test/unit/deploy_serializer_test.rb +++ b/test/unit/deploy_serializer_test.rb @@ -3,7 +3,7 @@ module Shipit class DeploySerializerTest < ActiveSupport::TestCase - test 'includes author object' do + test 'deploy commits includes author object' do deploy = shipit_deploys(:shipit) first_commit_author = deploy.commits.first.author From cdb2466442452776db4b9fe9a3896ab548e5f928 Mon Sep 17 00:00:00 2001 From: Vinicius Gama Date: Tue, 28 Jul 2020 16:57:45 -0300 Subject: [PATCH 3/3] Update test/unit/commit_serializer_test.rb Co-authored-by: Ben Langfeld --- test/unit/commit_serializer_test.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/commit_serializer_test.rb b/test/unit/commit_serializer_test.rb index befada120..5b3c82260 100644 --- a/test/unit/commit_serializer_test.rb +++ b/test/unit/commit_serializer_test.rb @@ -2,7 +2,7 @@ require 'test_helper' module Shipit - class DeploySerializerTest < ActiveSupport::TestCase + class CommitSerializerTest < ActiveSupport::TestCase test 'commit includes author object' do commit = shipit_commits(:first)