style: fix rubocop offenses in deploy_spec

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: DudeRandom21

app/models/shipit/deploy_spec.rb

@@ -87,7 +87,7 @@ def dependencies_steps
             Rails.logger.warn(
               "Skipping dependency installation: stack uses production_platform " \
               "and has no deploy steps requiring local dependencies. " \
-              "To override, set `dependencies.override` in your shipit.yml.",
+              "To override, set `dependencies.override` in your shipit.yml."
             )
             []
           else
@@ -293,12 +293,12 @@ def skip_dependencies_for_production_platform?
       # Similarly, discovered task definitions (e.g., kubernetes-restart) are inherently
       # safe commands and don't need to be checked here.
       all_steps = Array(config('deploy', 'override')) +
-        Array(config('deploy', 'pre')) +
-        Array(config('deploy', 'post')) +
-        Array(config('rollback', 'override')) +
-        Array(config('rollback', 'pre')) +
-        Array(config('rollback', 'post')) +
-        all_task_steps
+                  Array(config('deploy', 'pre')) +
+                  Array(config('deploy', 'post')) +
+                  Array(config('rollback', 'override')) +
+                  Array(config('rollback', 'pre')) +
+                  Array(config('rollback', 'post')) +
+                  all_task_steps
 
       all_steps = all_steps.compact
       return false if all_steps.empty?

test/models/deploy_spec_test.rb

@@ -55,15 +55,15 @@ class DeploySpecTest < ActiveSupport::TestCase
     test '#dependencies_steps returns empty when production_platform is configured and all steps are safe' do
       @spec.stubs(:load_config).returns(
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
-        'deploy' => { 'override' => ['production-platform-next deploy my-app production-unrestricted'] },
+        'deploy' => { 'override' => ['production-platform-next deploy my-app production-unrestricted'] }
       )
       assert_equal [], @spec.dependencies_steps
     end
 
     test '#dependencies_steps still discovers deps when production_platform has unsafe deploy steps' do
       @spec.stubs(:load_config).returns(
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
-        'deploy' => { 'override' => ['bundle exec rake deploy'] },
+        'deploy' => { 'override' => ['bundle exec rake deploy'] }
       )
       @spec.expects(:bundler?).returns(true).at_least_once
       @spec.expects(:bundle_install).returns(['bundle install'])
@@ -80,7 +80,7 @@ class DeploySpecTest < ActiveSupport::TestCase
     test '#dependencies_steps respects explicit override even with production_platform' do
       @spec.stubs(:load_config).returns(
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
-        'dependencies' => { 'override' => ['custom-install'] },
+        'dependencies' => { 'override' => ['custom-install'] }
       )
       assert_equal ['custom-install'], @spec.dependencies_steps
     end
@@ -89,7 +89,7 @@ class DeploySpecTest < ActiveSupport::TestCase
       @spec.stubs(:load_config).returns(
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
         'deploy' => { 'override' => ['production-platform-next deploy my-app production-unrestricted'] },
-        'dependencies' => { 'pre' => ['echo before'], 'post' => ['echo after'] },
+        'dependencies' => { 'pre' => ['echo before'], 'post' => ['echo after'] }
       )
       assert_equal ['echo before', 'echo after'], @spec.dependencies_steps
     end
@@ -98,8 +98,8 @@ class DeploySpecTest < ActiveSupport::TestCase
       @spec.stubs(:load_config).returns(
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
         'tasks' => {
-          'restart' => { 'steps' => ['production-platform-next run-once my-app production-unrestricted restart'] },
-        },
+          'restart' => { 'steps' => ['production-platform-next run-once my-app production-unrestricted restart'] }
+        }
       )
       assert_equal [], @spec.dependencies_steps
     end
@@ -108,8 +108,8 @@ class DeploySpecTest < ActiveSupport::TestCase
       @spec.stubs(:load_config).returns(
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
         'tasks' => {
-          'migrate' => { 'steps' => ['bundle exec rake db:migrate'] },
-        },
+          'migrate' => { 'steps' => ['bundle exec rake db:migrate'] }
+        }
       )
       @spec.expects(:bundler?).returns(true).at_least_once
       @spec.expects(:bundle_install).returns(['bundle install'])
@@ -119,15 +119,15 @@ class DeploySpecTest < ActiveSupport::TestCase
     test '#dependencies_steps skips deps when production_platform uses kubernetes-deploy' do
       @spec.stubs(:load_config).returns(
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
-        'deploy' => { 'override' => ['kubernetes-deploy --max-watch-seconds 900 my-namespace my-context'] },
+        'deploy' => { 'override' => ['kubernetes-deploy --max-watch-seconds 900 my-namespace my-context'] }
       )
       assert_equal [], @spec.dependencies_steps
     end
 
     test '#dependencies_steps falls through to discovery when deploy step has unknown command' do
       @spec.stubs(:load_config).returns(
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
-        'deploy' => { 'override' => ['some-unknown-deploy-tool --flag'] },
+        'deploy' => { 'override' => ['some-unknown-deploy-tool --flag'] }
       )
       @spec.expects(:discover_dependencies_steps).returns(nil).once
       assert_equal [], @spec.dependencies_steps
@@ -137,7 +137,7 @@ class DeploySpecTest < ActiveSupport::TestCase
       @spec.stubs(:load_config).returns(
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
         'deploy' => { 'override' => ['production-platform-next deploy my-app production-unrestricted'] },
-        'rollback' => { 'override' => ['bundle exec rake rollback'] },
+        'rollback' => { 'override' => ['bundle exec rake rollback'] }
       )
       @spec.expects(:bundler?).returns(true).at_least_once
       @spec.expects(:bundle_install).returns(['bundle install'])
@@ -149,8 +149,8 @@ class DeploySpecTest < ActiveSupport::TestCase
         'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
         'deploy' => {
           'pre' => ['bundle exec rake before_deploy'],
-          'override' => ['production-platform-next deploy my-app production-unrestricted'],
-        },
+          'override' => ['production-platform-next deploy my-app production-unrestricted']
+        }
       )
       @spec.expects(:bundler?).returns(true).at_least_once
       @spec.expects(:bundle_install).returns(['bundle install'])
@@ -159,7 +159,7 @@ class DeploySpecTest < ActiveSupport::TestCase
 
     test '#dependencies_steps does not skip when production_platform has no deploy override configured' do
       @spec.stubs(:load_config).returns(
-        'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] },
+        'production_platform' => { 'application' => 'my-app', 'runtime_ids' => ['production-unrestricted'] }
       )
       @spec.expects(:bundler?).returns(true).at_least_once
       @spec.expects(:bundle_install).returns(['bundle install'])